Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added glue code for dismissing an app #284

Open
wants to merge 21 commits into
base: deepLinkImplementation
Choose a base branch
from
Open

feat: added glue code for dismissing an app #284

wants to merge 21 commits into from
+133 −1

Conversation

anjalimukundan
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

Invalid PR title. It must start with feat: or fix: or BREAKING CHANGE: or feat(): or fix(): or BREAKING CHANGE():. Please see our Contributing-Guide.

@anjalimukundan anjalimukundan changed the title added glue code for dismissing an app feat: added glue code for dismissing an app Dec 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

Issue with linting detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/step_definitions/fireboltCalls.js
  425:16  error  Replace ``Sending·request·to·fetch·${appId}·app·state:·${JSON.stringify(requestMapForGetAppState)}`` with `⏎····`Sending·request·to·fetch·${appId}·app·state:·${JSON.stringify(requestMapForGetAppState)}`⏎··`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

neeradanelxsi
neeradanelxsi reviewed Dec 8, 2024
View reviewed changes
cypress/support/step_definitions/fireboltCalls.js Outdated
methods: {
'lifecycle.close': [],
},
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens for badger here ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we hardcoding the content object/validation objects in FCS ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to fixtures

jbigel
jbigel reviewed Dec 10, 2024
View reviewed changes
cypress/support/cypress-support/src/utils.js Outdated
// Reading the pattern content from the runtime environment variable
const value = runtimeEnv[pattern] !== undefined ? runtimeEnv[pattern] : match;
return functionName && functions[functionName] ? functions[functionName](value) : value;
// If the input contains '->', Consdering it as an object path and extracting the value from the object
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would something like

resolveAtRuntime('some {{object -> value.uppercaseFirstChar}}')

be handled?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking the order of operations should be check to see if there is a function in the pattern. Apply that function after we have handled any object extraction.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handled in deeplink PR

@github-actions GitHub Actions
Copy link

Build error occurred while running sample test with the following errors:

Error: Build failed with 1 error:
cypress/support/cypress-support/src/main.js:37:40: ERROR: Could not resolve "../../../fixtures/intentTemplates"
    at failureErrorWithLog (/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/node_modules/esbuild/lib/main.js:1636:15)
    at /home/runner/work/firebolt-certification-suite/firebolt-certification-suite/node_modules/esbuild/lib/main.js:1048:25
    at runOnEndCallbacks (/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/node_modules/esbuild/lib/main.js:1471:45)
    at buildResponseToResult (/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/node_modules/esbuild/lib/main.js:1046:7)

For more information on our testing policies, please see our Testing-Guide.

@github-actions GitHub Actions
Copy link

Issue with linting detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/fixtures/intentTemplates.js
  1:19  error  Delete `⏎`  prettier/prettier
  3:31  error  Insert `⏎`  prettier/prettier

✖ 2 problems (2 errors, 0 warnings)
  2 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

jbigel
jbigel reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@jbigel jbigel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but waiting to approve until deeplink has been merged

neeradanelxsi
neeradanelxsi reviewed Dec 16, 2024
View reviewed changes
cypress/support/step_definitions/fireboltCalls.js
) {
fireLog.info(
`State validation successful: Current state of ${appId} app is ${responseString} as expected`
);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 453 is not correct. we are not getting any app state and we are not validating app state here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the logs

neeradanelxsi
neeradanelxsi reviewed Dec 16, 2024
View reviewed changes
cypress/support/step_definitions/fireboltCalls.js Outdated
const responseString = JSON.stringify(response);
if (
// Check if response exists and contains appState, visibilityState
// and if appState is INACTIVE and visibilityState is VISIBLE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

give a generic comment on line 435. what is visibility state ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@anjalimukundan anjalimukundan changed the base branch from dev to deepLinkImplementation December 16, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neeradanelxsi neeradanelxsi neeradanelxsi left review comments

@jbigel jbigel jbigel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anjalimukundan @jbigel @neeradanelxsi @Abhishk123