Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIRECERT-2025-Migrate schema validation to FCS #43

Merged
merged 34 commits into from
Jul 1, 2024
Merged

Conversation

Nandana-NNR
Copy link
Contributor

@Nandana-NNR Nandana-NNR commented May 3, 2024

Copy link

github-actions bot commented May 3, 2024

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/step_definitions/fireboltCalls.js
   69:35   error  Replace `method,·params,·response,·Cypress.env(CONSTANTS.SDK_VERSION)` with `⏎············method,⏎············params,⏎············response,⏎············Cypress.env(CONSTANTS.SDK_VERSION)⏎··········`  prettier/prettier
  166:100  error  Insert `⏎············`                                                                                                                                                                                  prettier/prettier
  167:1    error  Insert `··`                                                                                                                                                                                             prettier/prettier
  168:13   error  Insert `··`                                                                                                                                                                                             prettier/prettier
  170:1    error  Insert `··`                                                                                                                                                                                             prettier/prettier
  171:13   error  Insert `··`                                                                                                                                                                                             prettier/prettier
  172:1    error  Insert `··`                                                                                                                                                                                             prettier/prettier
  173:13   error  Insert `··`                                                                                                                                                                                             prettier/prettier
  175:1    error  Insert `··`                                                                                                                                                                                             prettier/prettier
  176:13   error  Insert `··`                                                                                                                                                                                             prettier/prettier
  177:1    error  Replace `··············` with `················`                                                                                                                                                        prettier/prettier
  178:13   error  Insert `··`                                                                                                                                                                                             prettier/prettier
  180:1    error  Insert `··`                                                                                                                                                                                             prettier/prettier
  181:13   error  Insert `··`                                                                                                                                                                                             prettier/prettier
  182:1    error  Replace `··············` with `················`                                                                                                                                                        prettier/prettier
  183:1    error  Insert `··`                                                                                                                                                                                             prettier/prettier
  184:15   error  Insert `··`                                                                                                                                                                                             prettier/prettier
  185:1    error  Insert `··`                                                                                                                                                                                             prettier/prettier
  185:15   error  Expected space or tab after '//' in comment                                                                                                                                                             spaced-comment
  186:15   error  Insert `··`                                                                                                                                                                                             prettier/prettier
  187:15   error  Insert `··`                                                                                                                                                                                             prettier/prettier
  188:1    error  Replace `··············` with `················`                                                                                                                                                        prettier/prettier
  189:13   error  Insert `··`                                                                                                                                                                                             prettier/prettier
  190:1    error  Insert `··`                                                                                                                                                                                             prettier/prettier
  191:11   error  Replace `}` with `··}⏎··········`                                                                                                                                                                       prettier/prettier
  260:99   error  Insert `⏎············`                                                                                                                                                                                  prettier/prettier
  261:13   error  Insert `··`                                                                                                                                                                                             prettier/prettier
  262:1    error  Insert `··`                                                                                                                                                                                             prettier/prettier
  263:15   error  Insert `··`                                                                                                                                                                                             prettier/prettier
  264:1    error  Replace `············` with `··············`                                                                                                                                                            prettier/prettier
  266:1    error  Insert `··`                                                                                                                                                                                             prettier/prettier
  267:13   error  Insert `··`                                                                                                                                                                                             prettier/prettier
  268:1    error  Replace `··············` with `················`                                                                                                                                                        prettier/prettier
  269:1    error  Insert `··`                                                                                                                                                                                             prettier/prettier
  270:15   error  Insert `··`                                                                                                                                                                                             prettier/prettier
  271:1    error  Insert `··`                                                                                                                                                                                             prettier/prettier
  271:15   error  Expected space or tab after '//' in comment                                                                                                                                                             spaced-comment
  272:15   error  Insert `··`                                                                                                                                                                                             prettier/prettier
  273:15   error  Insert `··`                                                                                                                                                                                             prettier/prettier
  274:1    error  Insert `··`                                                                                                                                                                                             prettier/prettier
  275:13   error  Insert `··`                                                                                                                                                                                             prettier/prettier
  276:1    error  Insert `··`                                                                                                                                                                                             prettier/prettier
  277:11   error  Replace `}` with `··}⏎··········`                                                                                                                                                                       prettier/prettier
  344:101  error  Insert `⏎············`                                                                                                                                                                                  prettier/prettier
  345:1    error  Replace `············` with `··············`                                                                                                                                                            prettier/prettier
  346:1    error  Insert `··`                                                                                                                                                                                             prettier/prettier
  347:1    error  Replace `············` with `··············`                                                                                                                                                            prettier/prettier
  348:1    error  Insert `··`                                                                                                                                                                                             prettier/prettier
  349:13   error  Insert `··`                                                                                                                                                                                             prettier/prettier
  351:1    error  Insert `··`                                                                                                                                                                                             prettier/prettier
  352:13   error  Insert `··`                                                                                                                                                                                             prettier/prettier
  353:1    error  Replace `··············` with `················`                                                                                                                                                        prettier/prettier
  354:1    error  Insert `··`                                                                                                                                                                                             prettier/prettier
  355:15   error  Insert `··`                                                                                                                                                                                             prettier/prettier
  356:1    error  Insert `··`                                                                                                                                                                                             prettier/prettier
  357:15   error  Insert `··`                                                                                                                                                                                             prettier/prettier
  358:1    error  Insert `··`                                                                                                                                                                                             prettier/prettier
  359:13   error  Insert `··`                                                                                                                                                                                             prettier/prettier
  360:1    error  Replace `············` with `··············`                                                                                                                                                            prettier/prettier
  361:11   error  Replace `}` with `··}⏎··········`                                                                                                                                                                       prettier/prettier

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/step_definitions/validations.js
  112:49  error  Replace `methodOrEvent,·null,·result,·Cypress.env(CONSTANTS.SDK_VERSION)).then(` with `⏎··························methodOrEvent,⏎··························null,⏎··························result,⏎··························Cypress.env(CONSTANTS.SDK_VERSION)`  prettier/prettier
  113:25  error  Replace `··` with `).then(`                                                                                                                                                                                                                                       prettier/prettier
  114:1   error  Replace `····························` with `··························`                                                                                                                                                                                          prettier/prettier
  115:29  error  Delete `··`                                                                                                                                                                                                                                                       prettier/prettier
  116:1   error  Delete `··`                                                                                                                                                                                                                                                       prettier/prettier
  117:29  error  Delete `··`                                                                                                                                                                                                                                                       prettier/prettier
  118:29  error  Delete `··`                                                                                                                                                                                                                                                       prettier/prettier
  119:1   error  Replace `······························` with `····························`                                                                                                                                                                                      prettier/prettier
  120:27  error  Delete `··`                                                                                                                                                                                                                                                       prettier/prettier
  121:25  error  Replace `··}⏎························` with `}`                                                                                                                                                                                                                   prettier/prettier

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/validations/schemaValidation.js
   67:22  error  Replace `⏎··'updateResponseForFCS',⏎·` with `'updateResponseForFCS',`                                                                                                                                                                                                                prettier/prettier
   70:3   error  Delete `··`                                                                                                                                                                                                                                                                          prettier/prettier
   71:5   error  Delete `··`                                                                                                                                                                                                                                                                          prettier/prettier
   72:1   error  Replace `······` with `····`                                                                                                                                                                                                                                                         prettier/prettier
   73:1   error  Delete `··`                                                                                                                                                                                                                                                                          prettier/prettier
   74:7   error  Delete `··`                                                                                                                                                                                                                                                                          prettier/prettier
   75:1   error  Delete `··`                                                                                                                                                                                                                                                                          prettier/prettier
   77:1   error  Replace `······cy.validateSchema(⏎········response[responseType],⏎········methodOrEvent,⏎········params,⏎········sdkVersion,⏎········responseType⏎······).then(` with `····cy.validateSchema(response[responseType],·methodOrEvent,·params,·sdkVersion,·responseType).then(⏎······`  prettier/prettier
  142:8   error  Insert `⏎····`                                                                                                                                                                                                                                                                       prettier/prettier
  143:1   error  Delete `··`                                                                                                                                                                                                                                                                          prettier/prettier
  144:1   error  Delete `··`                                                                                                                                                                                                                                                                          prettier/prettier
  145:3   error  Delete `··`                                                                                                                                                                                                                                                                          prettier/prettier
  146:1   error  Replace `··}⏎` with `}`                                                                                                                                                                                                                                                              prettier/prettier

✖ 83 problems (83 errors, 0 warnings)
  83 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

Copy link

github-actions bot commented May 3, 2024

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/step_definitions/fireboltCalls.js
  191:17  error  Expected space or tab after '//' in comment  spaced-comment
  279:17  error  Expected space or tab after '//' in comment  spaced-comment

✖ 2 problems (2 errors, 0 warnings)
  2 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

Copy link

github-actions bot commented May 6, 2024

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/step_definitions/fireboltCalls.js
  174:19  error  'responseType' is never reassigned. Use 'const' instead   prefer-const
  268:17  error  'eventResponse' is never reassigned. Use 'const' instead  prefer-const

✖ 2 problems (2 errors, 0 warnings)
  2 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

Copy link

github-actions bot commented May 8, 2024

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/constants/constants.js
  202:27  error  Replace `⏎····'Lifecycle.ready',⏎····'Lifecycle.state',⏎····'Lifecycle.close'⏎··` with `'Lifecycle.ready',·'Lifecycle.state',·'Lifecycle.close'`  prettier/prettier
  416:2   error  Insert `⏎`                                                                                                                                        prettier/prettier

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/validations/schemaValidation.js
  287:3  error  Delete `··`                                                                                                                                                                                                                                                    prettier/prettier
  288:1  error  Replace `······const·stateSchema·=·cy.getSchema(⏎·······method,⏎········'',⏎········Cypress.env(CONSTANTS.SDK_VERSION),⏎········responseType⏎······` with `····const·stateSchema·=·cy.getSchema(method,·'',·Cypress.env(CONSTANTS.SDK_VERSION),·responseType`  prettier/prettier
  294:1  error  Delete `··`                                                                                                                                                                                                                                                    prettier/prettier
  295:5  error  Delete `··`                                                                                                                                                                                                                                                    prettier/prettier
  296:1  error  Delete `··`                                                                                                                                                                                                                                                    prettier/prettier
  297:5  error  Delete `··`                                                                                                                                                                                                                                                    prettier/prettier
  298:1  error  Delete `··`                                                                                                                                                                                                                                                    prettier/prettier
  299:1  error  Delete `··`                                                                                                                                                                                                                                                    prettier/prettier

✖ 10 problems (10 errors, 0 warnings)
  10 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

@rdkcmf-jenkins
Copy link

Coverity detected 3 issues; a quality concern.

Copy link

github-actions bot commented May 9, 2024

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/constants/constants.js
  202:27  error  Replace `⏎····'Lifecycle.ready',⏎····'Lifecycle.state',⏎····'Lifecycle.close'⏎··` with `'Lifecycle.ready',·'Lifecycle.state',·'Lifecycle.close'`  prettier/prettier
  417:2   error  Insert `⏎`                                                                                                                                        prettier/prettier

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/validations/schemaValidation.js
  287:3  error  Delete `··`                                                                                                                                                                                                                                                    prettier/prettier
  288:1  error  Replace `······const·stateSchema·=·cy.getSchema(⏎·······method,⏎········'',⏎········Cypress.env(CONSTANTS.SDK_VERSION),⏎········responseType⏎······` with `····const·stateSchema·=·cy.getSchema(method,·'',·Cypress.env(CONSTANTS.SDK_VERSION),·responseType`  prettier/prettier
  294:1  error  Delete `··`                                                                                                                                                                                                                                                    prettier/prettier
  295:5  error  Delete `··`                                                                                                                                                                                                                                                    prettier/prettier
  296:1  error  Delete `··`                                                                                                                                                                                                                                                    prettier/prettier
  297:5  error  Delete `··`                                                                                                                                                                                                                                                    prettier/prettier
  298:1  error  Delete `··`                                                                                                                                                                                                                                                    prettier/prettier
  299:1  error  Delete `··`                                                                                                                                                                                                                                                    prettier/prettier

✖ 10 problems (10 errors, 0 warnings)
  10 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

Copy link

github-actions bot commented May 9, 2024

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/constants/constants.js
  413:2  error  Insert `⏎`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

@Nandana-NNR Nandana-NNR requested a review from rdkcmf-jenkins May 9, 2024 10:41
Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/validations/schemaValidation.js
  52:13  error  'error' is never reassigned. Use 'const' instead  prefer-const

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

@Nandana-NNR Nandana-NNR requested a review from kschrief June 4, 2024 06:04
jbigel
jbigel previously approved these changes Jun 4, 2024
neeradanelxsi
neeradanelxsi previously approved these changes Jun 5, 2024
@Nandana-NNR Nandana-NNR dismissed stale reviews from neeradanelxsi and jbigel via 089f48f June 7, 2024 10:15
@rdkcmf-jenkins
Copy link

Coverity detected 1 issue; a security concern.

@Abhishk123 Abhishk123 merged commit 11be545 into dev Jul 1, 2024
5 checks passed
@Abhishk123 Abhishk123 deleted the FIRECERT-2025 branch July 1, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants