Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple cucumber report footer from landing page and individual modules #88

Merged
merged 14 commits into from
Jul 17, 2024
Merged

Decouple cucumber report footer from landing page and individual modules #88

merged 14 commits into from
Jul 17, 2024

Conversation

bpvstaty366
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/plugins/index.js
  301:40  error  Replace `"../fixtures/customFooter.json"` with `'../fixtures/customFooter.json'`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

parag-pv
parag-pv reviewed May 31, 2024
View reviewed changes
cypress/plugins/index.js Outdated Show resolved Hide resolved
@parag-pv
Copy link
Contributor

@bpvstaty366 Question: Is this only for combined runs or does it work for individual module runs? Say if only account is being run, will the inner page of account feature have the custom footer or the common footer from the home page?

@parag-pv
Copy link
Contributor

Question 2: The common footer in the landing page is right now fetched from the reportEnv.json in Lambda, is that something that can be overriden in FCS? We need the ability to customize the common footer as well without actually modifying anything in Lambda

@bpvstaty366
Copy link
Contributor Author

@parag-pv

  1. it works for both
  2. added PageFooter to the json, it will be the main source for lambda

@bpvstaty366 bpvstaty366 requested a review from parag-pv June 3, 2024 14:00
@parag-pv
Copy link
Contributor

Can we put the customReportFooters.json in configModule's cypress/fixtures?

  • Keep a base file in FCS but override it with whatever value is provided in configModule.
  • If a configModule does not have customReportFooters.json, use the data present in FCS.
  • Override the entire file for now, per key based override should be implemented in FIRECERT-2095, after which, the logic to override the footer data added in this ticket should be removed and the common logic from 2095 should be used.

@github-actions GitHub Actions
Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/plugins/index.js
  305:13  error  Delete `··`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

@bpvstaty366 bpvstaty366 requested a review from parag-pv June 10, 2024 13:05
parag-pv
parag-pv reviewed Jun 11, 2024
View reviewed changes
cypress/fixtures/customReportData.json Outdated Show resolved Hide resolved
cypress/plugins/index.js Outdated
@@ -298,7 +298,14 @@ module.exports = async (on, config) => {
jsonReport = readDataFromFile(filePath + fileName);
}
const reportProperties = {};
let customReportData;
try {
customReportData = require('../../node_modules/configModule/cypress/fixtures/objects/customReportData.json');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm if this does not get copied to FCS/cypress/fixtures/external when the setup is being done?

parag-pv
parag-pv previously approved these changes Jun 12, 2024
View reviewed changes
ksentak
ksentak previously approved these changes Jun 13, 2024
View reviewed changes
@bpvstaty366 bpvstaty366 dismissed stale reviews from ksentak and parag-pv via 278c7cf June 26, 2024 10:15
parag-pv
parag-pv previously approved these changes Jun 26, 2024
View reviewed changes
@Roebot926 Roebot926 requested a review from ksentak July 1, 2024 13:14
@jmeier204 jmeier204 merged commit b50a97c into dev Jul 17, 2024
3 checks passed
@jmeier204 jmeier204 deleted the firecert-2149 branch July 17, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmeier204 jmeier204 jmeier204 approved these changes

@ksentak ksentak ksentak approved these changes

@parag-pv parag-pv parag-pv left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bpvstaty366 @parag-pv @ksentak @jmeier204 @Roebot926