Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIRECERT-2113: [FCS] Process setResponseData in plugins #90

Merged
merged 6 commits into from
Jun 12, 2024

Conversation

SnehalP251
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Jun 5, 2024

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/plugins/testDataProcessor.js
  82:18  error  Insert `;`  prettier/prettier
  83:2   error  Delete `⏎`  prettier/prettier

✖ 2 problems (2 errors, 0 warnings)
  2 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

Copy link

github-actions bot commented Jun 5, 2024

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/plugins/testDataProcessor.js
  13:30  error  Insert `;`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

cypress/plugins/testDataProcessor.js Show resolved Hide resolved
cypress/plugins/testDataProcessor.js Outdated Show resolved Hide resolved
cypress/plugins/testDataProcessor.js Outdated Show resolved Hide resolved
Copy link
Contributor

@jbigel jbigel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So my understanding of the purpose of this ticket was to move logic to the plugin so we wouldn't have to do as much work during the test execution. I see we are handling that logic in the plugin but I would've expected that would mean we could simplify/remove code that is ran during execution.

Am I missing something?

@SnehalP251
Copy link
Contributor Author

So my understanding of the purpose of this ticket was to move logic to the plugin so we wouldn't have to do as much work during the test execution. I see we are handling that logic in the plugin but I would've expected that would mean we could simplify/remove code that is ran during execution.

Am I missing something?

The function parsedMockData added in command.js will return the response based on condition. In beforeOperation we will get the key and for setresponse the response would a processed data. so if object has a key then data would be processed else parsed response will be returned.

@Abhishk123 Abhishk123 merged commit c85e383 into dev Jun 12, 2024
5 checks passed
@Abhishk123 Abhishk123 deleted the FIRECERT-2113 branch June 12, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants