Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write projects overview in react #866

Merged
merged 3 commits into from
May 28, 2024

Conversation

CalamityC
Copy link
Collaborator

@CalamityC CalamityC commented Dec 8, 2023

Description

Related issue: #865

Motivation and Context

How has this been tested?

Screenshots (if appropriate)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

  • I have read the contributor guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • ⚠️ special tests for BASE_URL setting (!)

@jochenklar jochenklar changed the base branch from dev-2.1.0 to dev-2.2.0 December 12, 2023 13:46
@MyPyDavid MyPyDavid force-pushed the dev-2.2.0 branch 2 times, most recently from 4e64e34 to 6debf66 Compare January 17, 2024 08:22
@@ -13,6 +18,88 @@ class Meta:
fields = ('title', 'catalog')


class ProjectSearchFilterBackend(SearchFilter):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows for http://localhost:8000/api/v1/projects/projects/?search=olga%20child to search in title and the owners.

return queryset


class ProjectDateFilterBackend(BaseFilterBackend):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return datetime


class ProjectOrderingFilter(OrderingFilter):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows for ordering like this http://localhost:8000/api/v1/projects/projects/?ordering=owner. For owner, progres, and role the query needs to be annotated first.

@MyPyDavid MyPyDavid added this to the RDMO 2.2.0 milestone May 7, 2024
@MyPyDavid MyPyDavid linked an issue May 7, 2024 that may be closed by this pull request
@CalamityC CalamityC force-pushed the 865-write-projects-overview-in-react branch from 5d2ee04 to 8920c00 Compare May 16, 2024 15:27
@CalamityC CalamityC marked this pull request as ready for review May 17, 2024 12:23
@CalamityC CalamityC requested a review from jochenklar May 17, 2024 12:23
@jochenklar jochenklar marked this pull request as draft May 17, 2024 15:52
@CalamityC CalamityC force-pushed the 865-write-projects-overview-in-react branch from b897e76 to 4bb73c7 Compare May 17, 2024 15:59
@CalamityC CalamityC marked this pull request as ready for review May 21, 2024 08:22
@CalamityC CalamityC marked this pull request as draft May 21, 2024 08:22
@CalamityC CalamityC force-pushed the 865-write-projects-overview-in-react branch from 4bb73c7 to e16eb0c Compare May 23, 2024 09:37
@CalamityC CalamityC marked this pull request as ready for review May 23, 2024 10:39
@jochenklar
Copy link
Member

Looks good, can be merged. Thanks!

@CalamityC CalamityC merged commit 35dcd7b into dev-2.2.0 May 28, 2024
17 checks passed
@CalamityC CalamityC deleted the 865-write-projects-overview-in-react branch May 28, 2024 07:06
@MyPyDavid MyPyDavid linked an issue May 29, 2024 that may be closed by this pull request
@CalamityC CalamityC linked an issue May 29, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants