Skip to content

Commit

Permalink
Fix ambiguities in transform example (bevyengine#9845)
Browse files Browse the repository at this point in the history
# Objective

Fix these

```
 -- rotate_cube and move_cube
    conflict on: ["bevy_transform::components::transform::Transform", "transform::CubeState"]
 -- rotate_cube and scale_down_sphere_proportional_to_cube_travel_distance
    conflict on: ["bevy_transform::components::transform::Transform", "transform::CubeState"]
 -- move_cube and scale_down_sphere_proportional_to_cube_travel_distance
    conflict on: ["bevy_transform::components::transform::Transform", "transform::CubeState"]
```

The three systems in this example depend on the results of the others.
This leads to minor but detectable differences in output between runs by
automated screenshot diffing depending on the order of the schedule.

We don't necessarily need to be able to do this for **every** example,
but I think this is a case where fixing it is easy / maybe the right
thing to do anyway.

## Solution

Chain the three systems
  • Loading branch information
rparrett authored and Ray Redondo committed Jan 9, 2024
1 parent 19ec6e4 commit d225f8a
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion examples/transforms/transform.rs
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ fn main() {
move_cube,
rotate_cube,
scale_down_sphere_proportional_to_cube_travel_distance,
),
)
.chain(),
)
.run();
}
Expand Down

0 comments on commit d225f8a

Please sign in to comment.