fix(types): types for FormLabel (#5063)

* #5056 fix types for FormLabel Fixes #5056 and adds 'sm' and 'lg' as types for FormLabel column * Update simple.test.tsx Updated with test for types on Form.Label column Co-authored-by: Tor Raswill <tor.raswill@dqc.se>
react-bootstrap · Mar 24, 2020 · 42bd5af · 42bd5af
1 parent fbbb886
commit 42bd5af
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/types/components/FormLabel.d.ts b/types/components/FormLabel.d.ts
@@ -15,7 +15,7 @@ export interface FormLabelOwnProps extends FormLabelBaseProps {
 }
 
 export interface FormLabelWithColProps extends FormLabelBaseProps, ColProps {
-  column: true;
+  column: true | 'sm' | 'lg';
 }
 
 export type FormLabelProps = FormLabelWithColProps | FormLabelOwnProps;

diff --git a/types/simple.test.tsx b/types/simple.test.tsx
@@ -224,6 +224,14 @@ import {
       <Form.Control type="text" placeholder="Hoizontal" />
     </Col>
   </Form.Group>
+  <Form.Group as={Row} controlId="exampleForm.HorizontalControl">
+    <Form.Label column="sm" sm={2}>
+      Horizontal
+    </Form.Label>
+    <Col sm={10}>
+      <Form.Control type="text" placeholder="Hoizontal" />
+    </Col>
+  </Form.Group>
   <Form.File id="custom-file" label="Custom file input" custom />
   <Form.File
     ref={React.createRef<HTMLInputElement & FormFile>()}