Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add labelField and valueField for custom label field name and value field name #23

Merged
merged 7 commits into from
Apr 27, 2018

Conversation

405go
Copy link

@405go 405go commented Mar 7, 2018

Add labelField and valueField for custom label field name and value field name, It is not should just use value and label

@afc163
Copy link
Member

afc163 commented Apr 4, 2018

I think your PR is useful for ant-design/ant-design#9929

Could you finish it and add some test cases? @405go

@codecov-io
Copy link

codecov-io commented Apr 8, 2018

Codecov Report

Merging #23 into master will increase coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #23      +/-   ##
=========================================
+ Coverage    92.2%   92.4%   +0.19%     
=========================================
  Files           3       3              
  Lines         154     158       +4     
  Branches       50      54       +4     
=========================================
+ Hits          142     146       +4     
  Misses         12      12
Impacted Files Coverage Δ
src/Cascader.jsx 91.72% <100%> (+0.25%) ⬆️
src/Menus.jsx 95.45% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 776b2c3...3186e36. Read the comment docs.

@405go
Copy link
Author

405go commented Apr 8, 2018

@afc163 ok, i have finished

@afc163
Copy link
Member

afc163 commented Apr 8, 2018

How about filedNames={{ name: 'name', label: 'code', children: 'nodes' }} instead of three different props.

@405go
Copy link
Author

405go commented Apr 8, 2018

@afc163 It is a good ideal

@405go
Copy link
Author

405go commented Apr 8, 2018

@afc163 now it is good

@afc163 afc163 merged commit f893513 into react-component:master Apr 27, 2018
@afc163
Copy link
Member

afc163 commented Apr 27, 2018

Thx for you job!

BTW, your commit is not recognized by GitHub.

image

@405go
Copy link
Author

405go commented May 7, 2018

@afc163 It is our project style,It has become a habit.

@afc163
Copy link
Member

afc163 commented May 7, 2018

I mean this

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants