Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix throw error cause by import warning from rc-util #370

Merged
merged 1 commit into from
Oct 20, 2023
Merged

fix: fix throw error cause by import warning from rc-util #370

merged 1 commit into from
Oct 20, 2023

Conversation

kiner-tang
Copy link
Contributor

@kiner-tang kiner-tang commented Oct 20, 2023 •
edited
Loading

@vercel
Copy link

vercel bot commented Oct 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dialog ❌ Failed (Inspect) Oct 20, 2023 2:01am

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #370 (4850bdd) into master (695d01e) will not change coverage.
The diff coverage is n/a.

❗ Current head 4850bdd differs from pull request most recent head 09c46cb. Consider uploading reports for the commit 09c46cb to get more accurate results

@@           Coverage Diff           @@
##           master     #370   +/-   ##
=======================================
  Coverage   99.41%   99.41%           
=======================================
  Files           8        8           
  Lines         170      170           
  Branches       52       52           
=======================================
  Hits          169      169           
  Misses          1        1
Files Coverage Δ
src/Dialog/index.tsx 98.63% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

yoyo837
yoyo837 reviewed Oct 20, 2023
View reviewed changes
src/Dialog/index.tsx
@@ -10,7 +10,7 @@ import { getMotionName } from '../util';
import Content from './Content';
import type { ContentRef } from './Content/Panel';
import Mask from './Mask';
import { warning } from 'rc-util';
import { warning } from 'rc-util/lib/warning';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trigger 那边也有这个, 需要改不🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我去看看

Copy link
Contributor Author

@kiner-tang kiner-tang Oct 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

咋没看到有反馈说trigger有问题呢, 奇怪

@afc163 afc163 merged commit 5795478 into react-component:master Oct 20, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoyo837 yoyo837 yoyo837 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to resolve entry for package "rc-util" error when upgrade version
4 participants
@kiner-tang @yoyo837 @afc163 @lke-twh