Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix focus trap tabbing behaviour #393

Merged

Conversation

wahiche-ideal
Copy link
Contributor

@wahiche-ideal wahiche-ideal commented Jan 26, 2024

Copy link

vercel bot commented Jan 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dialog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 26, 2024 5:04pm

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fb2db17) 99.41% compared to head (2221c7f) 99.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #393   +/-   ##
=======================================
  Coverage   99.41%   99.41%           
=======================================
  Files           8        8           
  Lines         170      172    +2     
  Branches       52       52           
=======================================
+ Hits          169      171    +2     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yoyo837
Copy link
Member

yoyo837 commented Jan 27, 2024

LTGM

@yoyo837 yoyo837 merged commit e2d12f4 into react-component:master Jan 27, 2024
9 checks passed
@khalibloo
Copy link

When is the next release scheduled? Looks like the last one was quite a while ago.

@wahiche-ideal
Copy link
Contributor Author

There have been many releases since this was merged and accepted, when will this get into a release?

@yoyo837
Copy link
Member

yoyo837 commented Mar 12, 2024

We already published it out.

@khalibloo
Copy link

Hmm, I don't think the issue got fixed then. At least not in the antd docs. The issue is still present.

@wahiche-ideal
Copy link
Contributor Author

In what release did it get added?

@yoyo837
Copy link
Member

yoyo837 commented Mar 13, 2024

antd@5.15.0

@wahiche-ideal
Copy link
Contributor Author

I do not see it in the 5.15.0 list of items. Are you sure it has been merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal contains a focusable element that has no interactive content
3 participants