Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add autoFocus props for drawer #181

Merged
merged 3 commits into from
Jul 7, 2021
Merged

feat: add autoFocus props for drawer #181

merged 3 commits into from
Jul 7, 2021

Conversation

baxtergu
Copy link
Contributor

@baxtergu baxtergu commented Apr 1, 2021

@vercel
Copy link

vercel bot commented Apr 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/drawer/DqdEvCFrcWrQanBKp5x8Xx7Ka1uD
✅ Preview: https://drawer-git-fork-baxtergu-master-react-component.vercel.app

@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #181 (41ee7d9) into master (f5487f0) will increase coverage by 0.14%.
The diff coverage is 100.00%.

❗ Current head 41ee7d9 differs from pull request most recent head dbae1bb. Consider uploading reports for the commit dbae1bb to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
+ Coverage   71.53%   71.68%   +0.14%     
==========================================
  Files           3        3              
  Lines         390      392       +2     
  Branches      159      161       +2     
==========================================
+ Hits          279      281       +2     
  Misses        111      111              
Impacted Files Coverage Δ
src/DrawerWrapper.tsx 90.00% <ø> (ø)
src/DrawerChild.tsx 67.13% <100.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5487f0...dbae1bb. Read the comment docs.

@baxtergu
Copy link
Contributor Author

baxtergu commented Apr 1, 2021

Ready for review

@baxtergu
Copy link
Contributor Author

@afc163 @zombieJ

@vayyala
Copy link

vayyala commented Jul 6, 2021

Anything blocking merging this? Thanks!

@xrkffgg

@xrkffgg xrkffgg requested review from kerm1it and afc163 July 7, 2021 08:11
@kerm1it kerm1it merged commit c6f29c3 into react-component:master Jul 7, 2021
@kerm1it
Copy link
Member

kerm1it commented Jul 7, 2021

@afc163 publish minor version.

@afc163
Copy link
Member

afc163 commented Jul 7, 2021

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drawer autoFocus
5 participants