fix: optimize onChange index #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #181 +/- ##
===========================================
- Coverage 100.00% 99.08% -0.92%
===========================================
Files 7 7
Lines 312 329 +17
Branches 95 99 +4
===========================================
+ Hits 312 326 +14
- Misses 0 3 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@MadCcc 帮忙再看看 |
MadCcc
reviewed
Feb 15, 2023
Co-authored-by: MadCcc <1075746765@qq.com>
MadCcc
reviewed
Feb 15, 2023
| prevCurrent.current = prev; | ||
| } | ||
| }); | ||
| const [isShowPreview, setShowPreview] = useMergedState(!!previewVisible, { | ||
| value: previewVisible, | ||
| onChange: (val, prevVal) => { | ||
| onPreviewVisibleChange?.(val, prevVal); | ||
| onChange?.(current, prevCurrent.current); | ||
| onPreviewVisibleChange?.(val, prevVal, getSafeIndex(previewUrlsKeys, current)); |
There was a problem hiding this comment.
主要是考虑到会不会有用户有打开预览时获取当前索引的情况
MadCcc
reviewed
Feb 15, 2023
| @@ -30,19 +31,20 @@ describe('PreviewGroup', () => { | |||
| act(() => { | |||
| jest.runAllTimers(); | |||
| }); | |||
| expect(onChange).toHaveBeenCalledWith(1, undefined); | |||
| expect(onChange).not.toHaveBeenCalled(); | |||
| expect(onVisibleChange).toBeCalledWith(true, false, 0); | |||
There was a problem hiding this comment.
这个就是呀
expect(onChange).not.toHaveBeenCalled();
MadCcc
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.