Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: change default placeholder behavior, add previewPrefixCls prop #21

Merged
merged 1 commit into from
Aug 22, 2020

Conversation

shaodahong
Copy link
Member

@shaodahong shaodahong commented Aug 21, 2020

@vercel
Copy link

vercel bot commented Aug 21, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/image/ebkh3745u
✅ Preview: https://image-git-placeholder.react-component.vercel.app

@shaodahong shaodahong changed the title improve: change default placeholder, add previewPrefixCls prop improve: change default placeholder behavior, add previewPrefixCls prop Aug 21, 2020
@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #21   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          135       137    +2     
  Branches        30        32    +2     
=========================================
+ Hits           135       137    +2     
Impacted Files Coverage Δ
src/Image.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eb6ba7...b96d113. Read the comment docs.

@zombieJ
Copy link
Member

zombieJ commented Aug 22, 2020

approved~

@shaodahong shaodahong merged commit 3916478 into master Aug 22, 2020
@shaodahong shaodahong deleted the placeholder branch August 22, 2020 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants