Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should not load preview src when mount #265

Merged
merged 4 commits into from
Jun 28, 2023

Conversation

linxianxi
Copy link
Contributor

@linxianxi linxianxi commented Jun 28, 2023

#263

isImageValid 是 #187 故意为之

@vercel
Copy link

vercel bot commented Jun 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
image ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2023 8:58am

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #265 (8d89759) into master (6d19e7c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 8d89759 differs from pull request most recent head 6a4ca0a. Consider uploading reports for the commit 6a4ca0a to get more accurate results

@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
- Coverage   97.54%   97.53%   -0.01%     
==========================================
  Files          11       11              
  Lines         366      365       -1     
  Branches      105      105              
==========================================
- Hits          357      356       -1     
  Misses          9        9              
Impacted Files Coverage Δ
src/Image.tsx 96.10% <100.00%> (-0.05%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MadCcc
Copy link
Member

MadCcc commented Jun 28, 2023

来个 test case?

@linxianxi
Copy link
Contributor Author

来个 test case?

这个咋加?还能知道 network 里加不加载某个 src?

@MadCcc
Copy link
Member

MadCcc commented Jun 28, 2023

这个咋加?还能知道 network 里加不加载某个 src?

Mock 一下

@zombieJ zombieJ merged commit 4c6e814 into react-component:master Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants