-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: operation default icons #297
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #297 +/- ##
=======================================
Coverage 98.22% 98.22%
=======================================
Files 15 15
Lines 450 450
Branches 124 124
=======================================
Hits 442 442
Misses 7 7
Partials 1 1 ☔ View full report in Codecov by Sentry. |
src/Image.tsx
Outdated
@@ -98,7 +121,7 @@ const ImageInternal: CompoundedComponent<ImageProps> = props => { | |||
mask: previewMask, | |||
maskClassName, | |||
movable, | |||
icons, | |||
icons = defaultIcons, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
改 Image 逻辑了?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
只是加一个默认值,如果不传 icons 默认给一套 icons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不太清楚历史原因,尽量不动吧,只改 demo
不推荐这么做,rc 尽量不要依赖 icons |
那我就改一下demo 吧 |
Deployment failed with the following error:
|
No description provided.