Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addEventListener('wheel', onWheel) add { passive: false } #618

Merged
merged 1 commit into from
Jan 20, 2024
Merged

addEventListener('wheel', onWheel) add { passive: false } #618

merged 1 commit into from
Jan 20, 2024

Conversation

puxiao
Copy link
Contributor

@puxiao puxiao commented Jan 18, 2024

In Chrome:

InputNumber.js:431 [Violation] Added non-passive event listener to a scroll-blocking 'wheel' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952

Copy link

vercel bot commented Jan 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
input-number ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2024 1:31am

@yoyo837
Copy link
Member

yoyo837 commented Jan 18, 2024

Can you describe the origin issue?

@puxiao
Copy link
Contributor Author

puxiao commented Jan 18, 2024

Can you describe the origin issue?

@yoyo837 PTAL

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (26ca77b) 94.53% compared to head (989e969) 94.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #618   +/-   ##
=======================================
  Coverage   94.53%   94.53%           
=======================================
  Files           6        6           
  Lines         293      293           
  Branches       74       74           
=======================================
  Hits          277      277           
  Misses         16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yoyo837 yoyo837 merged commit 3323fbb into react-component:master Jan 20, 2024
11 checks passed
@puxiao puxiao deleted the patch-1 branch January 20, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants