Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cursor position when formatter appends characters on empty string #652

Merged
merged 6 commits into from
Jul 4, 2024

Conversation

pierluigigiancola
Copy link
Contributor

@pierluigigiancola pierluigigiancola commented Jul 3, 2024

resolve #651

Copy link

vercel bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
input-number ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2024 3:21am

@afc163
Copy link
Member

afc163 commented Jul 3, 2024

Could you add a test case for that?

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.28%. Comparing base (98b6025) to head (de85dc0).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
+ Coverage   94.52%   95.28%   +0.76%     
==========================================
  Files           6        6              
  Lines         292      297       +5     
  Branches       76       78       +2     
==========================================
+ Hits          276      283       +7     
+ Misses         16       14       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierluigigiancola
Copy link
Contributor Author

I revert the fix, add the test case to see it failed and then reapply the fix. If you want clearer git history I can close di PR, rewrite the history and issue a new one with test as first commit and fix as second

Let me know if I should add other tests

tests/cursor.test.tsx Outdated Show resolved Hide resolved
tests/cursor.test.tsx Outdated Show resolved Hide resolved
@afc163 afc163 merged commit e1f7727 into react-component:master Jul 4, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cursor position at end of string when formatter appends character
2 participants