-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cursor position when formatter appends characters on empty string #652
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Could you add a test case for that? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #652 +/- ##
==========================================
+ Coverage 94.52% 95.28% +0.76%
==========================================
Files 6 6
Lines 292 297 +5
Branches 76 78 +2
==========================================
+ Hits 276 283 +7
+ Misses 16 14 -2 ☔ View full report in Codecov by Sentry. |
I revert the fix, add the test case to see it failed and then reapply the fix. If you want clearer git history I can close di PR, rewrite the history and issue a new one with test as first commit and fix as second Let me know if I should add other tests |
resolve #651