-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: element remove leak #55
fix: element remove leak #55
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Walkthrough此次更改简化了 Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
我修了一下 lint,merge 一下 master~ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #55 +/- ##
==========================================
+ Coverage 98.45% 98.46% +0.01%
==========================================
Files 12 12
Lines 388 392 +4
Branches 109 109
==========================================
+ Hits 382 386 +4
Misses 6 6 ☔ View full report in Codecov by Sentry. |
|
Description
清理掉remove状态的元素 否则元素并不会被释放造成了内存泄漏的情况
Visuals
修改前的dom节点:
修改后的dom节点:
修改后元素始终保持一个数值内 之前并没有清理掉remove状态的元素
Checklist
Any TODOs?
A summary of any remaining work required to complete the requirements of the task.
Summary by CodeRabbit
Summary by CodeRabbit