Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: picker change won't change panel #121

Merged
merged 2 commits into from
Aug 7, 2020
Merged

fix: picker change won't change panel #121

merged 2 commits into from
Aug 7, 2020

Conversation

07akioni
Copy link
Contributor

@07akioni 07akioni commented Aug 7, 2020

@vercel
Copy link

vercel bot commented Aug 7, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/picker/54s10rcsl
✅ Preview: https://picker-git-fix-picker-change.react-component.vercel.app

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Aug 7, 2020

This pull request introduces 1 alert when merging 2c73203 into 5b30fac - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #121 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files          45       45           
  Lines        1967     1969    +2     
  Branches      588      588           
=======================================
+ Hits         1959     1961    +2     
  Misses          6        6           
  Partials        2        2           
Impacted Files Coverage Δ
src/PickerPanel.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b30fac...2c73203. Read the comment docs.

@zombieJ zombieJ merged commit 27c3b0a into master Aug 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-picker-change branch August 7, 2020 03:01
@zombieJ
Copy link
Member

zombieJ commented Aug 7, 2020

+ rc-picker@2.0.3

07akioni added a commit that referenced this pull request Aug 10, 2020
* fix: picker change won't change type

* fix: test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect DatePicker dropdown shown
2 participants