fix: activeBar offset not right when start from the opposite direction #889
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Walkthrough此次更改涉及 Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)src/PickerInput/Selector/RangeSelector.tsx (1)
通过解构方式移除了 建议执行以下测试以验证修复效果： ✅ Verification successfulLet me generate additional scripts to verify the changes more thoroughly. Based on the results, I can now generate the final response as we have sufficient information about the implementation. activeBar 位置修复验证完成 代码修改是正确且完整的。通过分析发现：
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# 描述：查找所有可能影响 activeBar 位置的相关代码
# 测试：检查是否有其他地方修改了 activeBar 样式
rg "activeBarStyle|insetInline"
# 测试：检查是否有其他组件依赖这些样式属性
ast-grep --pattern 'style={$_}'
Length of output: 641 Script: #!/bin/bash
# 检查 RangeSelector 组件的完整实现以理解 activeBarStyle 的使用上下文
ast-grep --pattern 'const RangeSelector = $_'
# 检查 uiUtil.ts 中的相关函数实现
cat src/utils/uiUtil.ts
# 查找可能的测试文件
fd "RangeSelector.test" --type f
Length of output: 4971 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Co-authored-by: Dmaziyo <Dmaziyo@users.noreply.github.com> close react-component#889 ref: ant-design/ant-design#51480
|
给个测试用例吧 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #889 +/- ##
=======================================
Coverage 95.43% 95.43%
=======================================
Files 64 64
Lines 2719 2719
Branches 762 762
=======================================
Hits 2595 2595
Misses 121 121
Partials 3 3 ☔ View full report in Codecov by Sentry. |
修改弹窗位置为相反的方向时，activeBar的位置出现错误
因为添加insetInlineStart/或insetInlineEnd的时候并未清除原有的样式
相关问题：
close ant-design/ant-design#51480
Summary by CodeRabbit
RangeSelector组件的样式更新逻辑，以优化活动条的外观。