fix: add root element for SingleSelector to make layout easier #1076
+198
−161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1076 +/- ##
=======================================
Coverage 98.23% 98.23%
=======================================
Files 39 39
Lines 1474 1474
Branches 439 445 +6
=======================================
Hits 1448 1448
Misses 26 26 ☔ View full report in Codecov by Sentry. |
zombieJ
reviewed
Oct 11, 2024
| @@ -77,7 +77,7 @@ const SingleSelector: React.FC<SelectorProps> = (props) => { | |||
| }, [item, hasTextInput, placeholder, prefixCls]); | |||
|
|
|||
| return ( | |||
| <> | |||
| <span className={`${prefixCls}-selection`}> | |||
There was a problem hiding this comment.
我记得其他 items 也是叫 selection，这个能改个 className 不
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
经过试验在 Ant Design 调整 prefix 的布局十分困难，因此需要在 SingleSelector 增加一个 wrapper 元素，来限制布局。