Introduce jest and enzyme #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yesmeck
commented
Nov 14, 2016
| done(); | ||
| }); | ||
| }); | ||
|
|
||
| it('should add css class of root dom node', () => { |
There was a problem hiding this comment.
像这种 DOM 结构是不是渲染正确的，直接用 snapshot 测试，可以省事很多，而且覆盖率也更高。
yesmeck
commented
Nov 14, 2016
| const input = TestUtils.findRenderedDOMComponentWithTag(instance, 'input'); | ||
| ); | ||
|
|
||
| const input = wrapper.find('input'); |
There was a problem hiding this comment.
enzyme 之于 React 就像 jQuery 之于 DOM，操作 Component 会简单很多。
|
coverage 怎么搞？ |
|
jest 自带了的 |
|
可以，全部改了，改好我合并 |
|
注意 coveralls.io 能否正确运行 |
yesmeck
force-pushed
the
introduce-jest
branch
from
92d8380
to
2d49bb9
Compare
yesmeck
force-pushed
the
introduce-jest
branch
from
2d49bb9
to
7cab4d9
Compare
yesmeck
force-pushed
the
introduce-jest
branch
from
7cab4d9
to
6d572aa
Compare
|
这边已经把所有 expect 的写法都改了，具体测试现在用 jQuery 来写的地方我看情况后面补测试的时候再调整为 enzyme 和 snapshot。 coverage 的计算结果要比原来的低，暂时不知道为什么。 |
|
改完需要合并时通知 |
|
已经改完了，这个可以合并了。 我后面补的测试再另外 PR。 |
|
貌似不能 npm run chrome-test 浏览器中调试了... 能用么 |
|
这样是可以的： 这样有问题 jestjs/jest#1652 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mocha 迁移到 jest 只要调整下 expect 的写法，这里只转换了一部分，看看行不行。
运行：
npm run jest