Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support custom label render #995

Merged
merged 11 commits into from
Jan 2, 2024

Conversation

xliez
Copy link
Contributor

@xliez xliez commented Dec 5, 2023

Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
select ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 3:19pm

@yoyo837
Copy link
Member

yoyo837 commented Dec 5, 2023

需要添加测试用例

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b6f4829) 99.78% compared to head (6814fea) 99.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #995   +/-   ##
=======================================
  Coverage   99.78%   99.78%           
=======================================
  Files          38       38           
  Lines        1396     1396           
  Branches      390      390           
=======================================
  Hits         1393     1393           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xliez
Copy link
Contributor Author

xliez commented Dec 5, 2023

需要添加测试用例

补充了tests、doc、demo

src/Select.tsx Outdated Show resolved Hide resolved
xliez and others added 3 commits December 5, 2023 21:51
@xliez
Copy link
Contributor Author

xliez commented Dec 8, 2023

@yoyo837 这个可以 merge 吗

@yoyo837
Copy link
Member

yoyo837 commented Dec 8, 2023

@yoyo837 这个可以 merge 吗

CI修复下

Signed-off-by: xliez <xliez@foxmail.com>
@xliez
Copy link
Contributor Author

xliez commented Dec 8, 2023

@yoyo837 这个可以 merge 吗

CI修复下

Done

src/Select.tsx Show resolved Hide resolved
@xliez
Copy link
Contributor Author

xliez commented Dec 14, 2023

有大佬处理下这个 MR 吗?

tests/Select.test.tsx Outdated Show resolved Hide resolved
@xliez
Copy link
Contributor Author

xliez commented Dec 25, 2023

@zombieJ 再看看可不可以

src/Select.tsx Outdated Show resolved Hide resolved
Signed-off-by: xliez <xliez@foxmail.com>
@yoyo837
Copy link
Member

yoyo837 commented Jan 2, 2024

冲突了。

@xliez
Copy link
Contributor Author

xliez commented Jan 2, 2024

冲突了。

处理了。

@yoyo837 yoyo837 merged commit 9a7fc96 into react-component:master Jan 2, 2024
11 checks passed
@xliez xliez deleted the feat/label-render branch January 24, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

select 组件当 option 中没有找到对应 value 时,能否自定义回显值,现在是 value
4 participants