support aria #260
Merged
support aria #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paranoidjk
reviewed
May 5, 2017
| @@ -4,15 +4,23 @@ import PropTypes from 'prop-types'; | |||
| export default class Handle extends React.Component { | |||
| render() { | |||
| const { | |||
| className, vertical, offset, handleStyle, ...restProps, | |||
| className, vertical, offset, handleStyle, disabled, min, max, value, ...restProps, | |||
There was a problem hiding this comment.
这里会导致下面的 handle div 少一个 disabled 属性吧
There was a problem hiding this comment.
div 不应该有 disabled 属性吧 @paranoidjk
There was a problem hiding this comment.
恩，是的，看来是之前的代码有bug，那这里会导致snapshot都要更新了
https://stackoverflow.com/questions/6307586/how-should-disabled-div-act
| @@ -21,7 +21,7 @@ const handle = (props) => { | |||
| placement="top" | |||
| key={index} | |||
| > | |||
| <Handle {...restProps} /> | |||
| <Handle value={value} {...restProps} /> | |||
There was a problem hiding this comment.
ant-design 少个value，break change，rc-slider 要发大版本。
到 ant-design 那边也提个PR WIP 修下吧
There was a problem hiding this comment.
|
ping @silentcloud 这个进度怎么样了？ |
|
囧，消息通知太多，可能没看到，等会看看 |
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ant-design/ant-design-mobile#1179