Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #279 - Use getBoundingClientRect for proper scaled width of slider #289

Closed
wants to merge 1 commit into from

Conversation

dbryand
Copy link

@dbryand dbryand commented Jun 21, 2017

Jcqt-390's solution also worked for me:
#279

@dbryand
Copy link
Author

dbryand commented Jun 21, 2017

I see now that this gives failing tests. Will take a look.

@captbaritone
Copy link
Contributor

captbaritone commented Jul 1, 2017

I've cherry-picked your commit into a separate pull request which also resolves the failing tests. #293

@benjycui
Copy link
Member

benjycui commented Jul 3, 2017

@dbryand could you fix the CI and add a unit test for this?

@benjycui
Copy link
Member

benjycui commented Jul 3, 2017

add a unit test for this?

Oops.. it seems that it is hard to add unit test for this. But please fix CI at least.

@dbryand
Copy link
Author

dbryand commented Jul 3, 2017 via email

@paranoidjk
Copy link
Member

@dbryand 👍
Thx, your commit have been merged in #293

@paranoidjk paranoidjk closed this Jul 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants