Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change event binding to slider ownerDocument #326

Merged
merged 2 commits into from
Oct 18, 2017

Conversation

zvcolpdy
Copy link
Contributor

@zvcolpdy zvcolpdy commented Oct 3, 2017

I noticed a problem that events binding to document. It has problem in frames that has they own document. It is better to use el.ownerDocument to add all slider event listeners.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.739% when pulling 88e1375 on polkpolio1:events-in-frame into 0a07ada on react-component:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.739% when pulling 6f1867b on polkpolio1:events-in-frame into 0a07ada on react-component:master.

@benjycui
Copy link
Member

Agree, but could you just show the problem with online demo? Thanks.

Please provide a re-producible demo: http://codepen.io/benjycui/pen/aJooRE?editors=0011

@zvcolpdy
Copy link
Contributor Author

@benjycui benjycui merged commit aae0498 into react-component:master Oct 18, 2017
@benjycui
Copy link
Member

8.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants