Fixed issue where controlled Range sliders with allowCross=false and … #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…more than two handles would change values of handles that aren't currentøy being dragged
|
Added a test case that describes the original issue I encountered with issue #226, along with a proposed fix. This is basically my first open source contribution, so any feedback would be appreciated! Edit: Apparently I did something weird when creating the first commit so that the git pre-hook didn't run :| |
|
similar to #304 , the cause is wrong handle, didn't pass |
Merged
|
@Robin-front: very similar indeed! It looks like your pull request is missing a test case for this particular issue however. Maybe I could limit the pull request to this. |
|
#304 has been merged, try 8.6.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…more than two handles would change values of handles that aren't currently being dragged
This fully(?) solves issue #226