Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update getLowerBound and getUpperBound to check startPoint prop #683

Conversation

mkantz84
Copy link
Contributor

In relation to issue #682, i updated the lower and upper bounds relative to the startPoint

@mkantz84
Copy link
Contributor Author

It seems like the CI failed on something that is not related to the changes that I've made.
What is the problem here?

image

@vercel
Copy link

vercel bot commented Sep 29, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/slider/fb6g6pdr2
✅ Preview: https://slider-git-fork-mkantz84-using-startpoint-sets-t-7e5691.react-component.vercel.app

@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #683 into master will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #683      +/-   ##
==========================================
+ Coverage   88.08%   88.16%   +0.08%     
==========================================
  Files          10       10              
  Lines         688      693       +5     
  Branches      182      185       +3     
==========================================
+ Hits          606      611       +5     
  Misses         82       82              
Impacted Files Coverage Δ
src/Slider.tsx 92.47% <100.00%> (+0.25%) ⬆️
src/Range.tsx 75.67% <0.00%> (ø)
src/index.tsx 100.00% <0.00%> (ø)
src/common/createSlider.tsx 94.63% <0.00%> (ø)
src/common/Steps.tsx 96.15% <0.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80b0bf6...fef6dd7. Read the comment docs.

@mkantz84
Copy link
Contributor Author

Is there any reason this PR has not been reviewed / merged?

@ktaras
Copy link

ktaras commented Oct 30, 2020

Any updates on this PR? I'm really waiting for this fix.

@afc163 afc163 merged commit 0e161bd into react-component:master Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants