fix: allow step prop to be null for typescript #691
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using null step Slider in Typescript, the linter complains that
step
cannot be null when used:In the API is is clearly mentioned that step can be null:
null
1
max
-min
should be evenly divisible by the step value.When
marks
is not an empty object,step
can be set tonull
, to makemarks
as steps.This PR is to fix the type definition so that it doesn't show the error above.