Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type definition bug #695

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Fix type definition bug #695

merged 1 commit into from
Oct 9, 2020

Conversation

Lazyuki
Copy link
Contributor

@Lazyuki Lazyuki commented Oct 9, 2020

I'm getting this error.

node_modules/rc-slider/lib/Slider.d.ts:3:18 - error TS2430: Interface 'SliderProps' incorrectly extends interface 'GenericSliderProps'.
  Types of property 'step' are incompatible.
    Type 'number | null | undefined' is not assignable to type 'number | undefined'.
      Type 'null' is not assignable to type 'number | undefined'.

3 export interface SliderProps extends GenericSliderProps {
                   ~~~~~~~~~~~

This is breaking my build so it would be nice if you could release a new patch version after this PR. Thanks.

@vercel
Copy link

vercel bot commented Oct 9, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/slider/gsyaubpog
✅ Preview: https://slider-git-patch-1.react-component.vercel.app

@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #695 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #695   +/-   ##
=======================================
  Coverage   88.26%   88.26%           
=======================================
  Files          10       10           
  Lines         690      690           
  Branches      181      181           
=======================================
  Hits          609      609           
  Misses         81       81           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef9a753...289d9ee. Read the comment docs.

@afc163 afc163 merged commit 6fc0805 into react-component:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants