Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Pure FC with multiple update #812

Merged
merged 55 commits into from
Feb 28, 2022
Merged

refactor: Pure FC with multiple update #812

merged 55 commits into from
Feb 28, 2022

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Feb 27, 2022

  • click mark to update range value
  • handleRender
  • Fix handle with count not correct
  • Fix pushable not work in some case
  • No more FindDOMNode
  • Move all position related style into inline style
  • Key: up is plus, down is minus
  • fix Key with step = null not align with marks
  • Change range should not trigger onChange
  • keyboard support pushable

@vercel
Copy link

vercel bot commented Feb 27, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/slider/G9bUVySgPXB93QFSfZu6r1eVGWYZ
✅ Preview: https://slider-git-refactor-react-component.vercel.app

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Feb 27, 2022

This pull request introduces 1 alert when merging c8e9af1 into 9d6dcc5 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@codecov
Copy link

codecov bot commented Feb 27, 2022

Codecov Report

Merging #812 (8d6988c) into master (9d6dcc5) will increase coverage by 11.31%.
The diff coverage is 99.81%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #812       +/-   ##
===========================================
+ Coverage   88.49%   99.81%   +11.31%     
===========================================
  Files          11       13        +2     
  Lines         756      529      -227     
  Branches      195      135       -60     
===========================================
- Hits          669      528      -141     
+ Misses         87        1       -86     
Impacted Files Coverage Δ
src/Tracks/index.tsx 94.44% <94.44%> (ø)
src/Handles/Handle.tsx 100.00% <100.00%> (ø)
src/Handles/index.tsx 100.00% <100.00%> (ø)
src/Marks/Mark.tsx 100.00% <100.00%> (ø)
src/Marks/index.tsx 100.00% <100.00%> (ø)
src/Slider.tsx 100.00% <100.00%> (+8.16%) ⬆️
src/Steps/Dot.tsx 100.00% <100.00%> (ø)
src/Steps/index.tsx 100.00% <100.00%> (ø)
src/Tracks/Track.tsx 100.00% <100.00%> (ø)
src/context.ts 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d6dcc5...8d6988c. Read the comment docs.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Feb 27, 2022

This pull request introduces 1 alert when merging cf7c025 into 9d6dcc5 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Feb 27, 2022

This pull request introduces 1 alert when merging 5bf125d into 9d6dcc5 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Feb 27, 2022

This pull request introduces 1 alert when merging 8d6988c into 9d6dcc5 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant