-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Pure FC with multiple update #812
Conversation
zombieJ
commented
Feb 27, 2022
- click mark to update range value
- handleRender
- Fix handle with count not correct
- Fix pushable not work in some case
- No more FindDOMNode
- Move all position related style into inline style
- Key: up is plus, down is minus
- fix Key with step = null not align with marks
- Change range should not trigger onChange
- keyboard support pushable
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/slider/G9bUVySgPXB93QFSfZu6r1eVGWYZ |
This pull request introduces 1 alert when merging c8e9af1 into 9d6dcc5 - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #812 +/- ##
===========================================
+ Coverage 88.49% 99.81% +11.31%
===========================================
Files 11 13 +2
Lines 756 529 -227
Branches 195 135 -60
===========================================
- Hits 669 528 -141
+ Misses 87 1 -86
Continue to review full report at Codecov.
|
This pull request introduces 1 alert when merging cf7c025 into 9d6dcc5 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 5bf125d into 9d6dcc5 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 8d6988c into 9d6dcc5 - view on LGTM.com new alerts:
|