Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: page crash when dots is true and step is null #838

Merged
merged 3 commits into from
Jul 6, 2022

Conversation

denghuacc
Copy link

@vercel
Copy link

vercel bot commented Jul 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
slider ✅ Ready (Inspect) Visit Preview Jul 6, 2022 at 7:39AM (UTC)

@MadCcc
Copy link
Member

MadCcc commented Jul 6, 2022

Could you provide a test case?

@denghuacc
Copy link
Author

denghuacc commented Jul 6, 2022

有没有更好的测试方法?
在没有修复这个 Bug 之前,如果使用了这个测试用例是会一直卡住的,无法结束测试。

@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #838 (ad819ad) into master (b50dbed) will not change coverage.
The diff coverage is 100.00%.

❗ Current head ad819ad differs from pull request most recent head e8fe468. Consider uploading reports for the commit e8fe468 to get more accurate results

@@           Coverage Diff           @@
##           master     #838   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          13       13           
  Lines         535      535           
  Branches      148      148           
=======================================
  Hits          534      534           
  Misses          1        1           
Impacted Files Coverage Δ
src/Steps/index.tsx 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider dot property crashes browser
3 participants