Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Handle): add aria-orientation on handles #859

Merged
merged 2 commits into from
Apr 15, 2023

Conversation

5im0n
Copy link
Contributor

@5im0n 5im0n commented Feb 16, 2023

The aria-orientation attribute indicates whether the element's orientation is horizontal, vertical.

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-orientation

@vercel
Copy link

vercel bot commented Feb 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
slider ❌ Failed (Inspect) Feb 16, 2023 at 1:51PM (UTC)

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@3bb74da). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head fe245c5 differs from pull request most recent head 7c9ab5b. Consider uploading reports for the commit 7c9ab5b to get more accurate results

@@            Coverage Diff            @@
##             master     #859   +/-   ##
=========================================
  Coverage          ?   99.81%           
=========================================
  Files             ?       13           
  Lines             ?      537           
  Branches          ?      149           
=========================================
  Hits              ?      536           
  Misses            ?        1           
  Partials          ?        0           
Impacted Files Coverage Δ
src/Handles/Handle.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

tests/Range.test.js Outdated Show resolved Hide resolved
tests/Range.test.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants