Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slider track draggale range height/width error #908

Merged
merged 2 commits into from
May 30, 2023

Conversation

@vercel
Copy link

vercel bot commented May 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
slider ❌ Failed (Inspect) May 30, 2023 0:41am

src/Tracks/Track.tsx Outdated Show resolved Hide resolved
assets/index.less Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Merging #908 (a0b85e9) into master (a951a0b) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head a0b85e9 differs from pull request most recent head 8092679. Consider uploading reports for the commit 8092679 to get more accurate results

@@            Coverage Diff             @@
##           master     #908      +/-   ##
==========================================
- Coverage   99.81%   99.81%   -0.01%     
==========================================
  Files          13       13              
  Lines         537      536       -1     
  Branches      140      139       -1     
==========================================
- Hits          536      535       -1     
  Misses          1        1              
Impacted Files Coverage Δ
src/Tracks/Track.tsx 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

src/Tracks/Track.tsx Outdated Show resolved Hide resolved
@MadCcc MadCcc merged commit 26c8bd7 into react-component:master May 30, 2023
@miloszmaki
Copy link

@BoyYangzai thanks for the fix, dragging works well now 👍
however there is some subtle rendering issue now, the track is being rendered over the handles, see https://codesandbox.io/s/draggable-slider-forked-dw6ele

@BoyYangzai
Copy link
Contributor Author

@miloszmaki
hello
i just adjust the css
maybe it's normal reder?
can you describe carefully more

@miloszmaki
Copy link

@BoyYangzai
this is how it looked before (v10.1.1): https://codesandbox.io/s/draggable-slider-izgbr4
before
and this is how it looks now (v10.2.0): https://codesandbox.io/s/draggable-slider-forked-dw6ele
now

@BoyYangzai
Copy link
Contributor Author

@miloszmaki done~
#912

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpredictable behaviour of a draggable track slider Unpredictable behaviour of a draggable track slider
5 participants