-
-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrects the element that aria- props are applied to #855
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #855 +/- ##
=======================================
Coverage 99.40% 99.40%
=======================================
Files 36 36
Lines 1004 1005 +1
Branches 304 304
=======================================
+ Hits 998 999 +1
Misses 6 6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@afc163 This fixes one of the most glaring a11y issues with react-component/table. Can you please merge it? |
@zombieJ Can you merge this please? |
aria- attributes should be applied to the
<table>
element. Instead, they are applied to the great grandparent of the<table>
element where they serve no purpose. eg:This PR moves them to the correct element. As a result, screen readers will correctly announce the table.
This PR does NOT change where the data- props are added (still on the great grandparent of the
<table>
element).ref: UIEN-973