Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: onHeaderCell missing title #929

Merged
merged 2 commits into from
Jan 4, 2023
Merged

fix: onHeaderCell missing title #929

merged 2 commits into from
Jan 4, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jan 4, 2023

No description provided.

@vercel
Copy link

vercel bot commented Jan 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
table ✅ Ready (Inspect) Visit Preview Jan 4, 2023 at 11:07AM (UTC)

@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Merging #929 (0ab3984) into master (12ddc99) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 0ab3984 differs from pull request most recent head c65aef2. Consider uploading reports for the commit c65aef2 to get more accurate results

@@           Coverage Diff           @@
##           master     #929   +/-   ##
=======================================
  Coverage   99.49%   99.49%           
=======================================
  Files          35       35           
  Lines         982      983    +1     
  Branches      311      313    +2     
=======================================
+ Hits          977      978    +1     
  Misses          5        5           
Impacted Files Coverage Δ
src/Cell/index.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zombieJ zombieJ merged commit 087bf6c into master Jan 4, 2023
@zombieJ zombieJ deleted the fix-title branch January 4, 2023 11:10
children: childNode,
});
const title =
additionalProps.title ??
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个换行看着有点难受

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该是 prettier 的风格,无须关心。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants