Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: make column support jsx conditions (#40568) #954

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

RedJue
Copy link
Contributor

@RedJue RedJue commented Feb 15, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #40568

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Make Table's columns support conditional rendering
🇨🇳 Chinese 让 Table 的 column 支持条件判断渲染

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@vercel
Copy link

vercel bot commented Feb 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
table ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 15, 2023 at 10:14AM (UTC)

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #954 (8e999fd) into master (27a8241) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 8e999fd differs from pull request most recent head e9c3955. Consider uploading reports for the commit e9c3955 to get more accurate results

@@           Coverage Diff           @@
##           master     #954   +/-   ##
=======================================
  Coverage   99.49%   99.49%           
=======================================
  Files          36       36           
  Lines         986      988    +2     
  Branches      316      317    +1     
=======================================
+ Hits          981      983    +2     
  Misses          5        5           
Impacted Files Coverage Δ
src/hooks/useColumns.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

src/hooks/useColumns.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make all api that accept JSON instead of JSX accept null
2 participants