fix: table warning message when columns=[] #966

Francoshum95 · 2023-03-13T13:03:50Z

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

Issue: Error message logged on the console when columns is empty []. This issue occurs in the custom body component:

<Table
 {...props}
 components={{
          body: renderSomethinig,
        }}
/>

After looking into it, I find that there's no major issue when columns is empty []. So, I just added a conditional check to only log an error if columns.length > 0.

📝 Changelog

Language	Changelog
🇺🇸 English	fix error message being logged in the custom body component when columns is empty []
🇨🇳 Chinese	修复自定义 body component, columns[] 為空時错误报错错误报

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

Doc is updated/provided or not needed
Demo is updated/provided or not needed
TypeScript definition is updated/provided or not needed
Changelog is provided or not needed

vercel · 2023-03-13T13:03:55Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
table	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 13, 2023 at 1:05PM (UTC)

codecov · 2023-03-17T03:34:21Z

Codecov Report

Merging #966 (b48756a) into master (3d731c4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head b48756a differs from pull request most recent head 659bc01. Consider uploading reports for the commit 659bc01 to get more accurate results

@@           Coverage Diff           @@
##           master     #966   +/-   ##
=======================================
  Coverage   99.49%   99.49%           
=======================================
  Files          36       36           
  Lines         988      989    +1     
  Branches      319      305   -14     
=======================================
+ Hits          983      984    +1     
  Misses          5        5

Impacted Files	Coverage Δ
src/Table.tsx	`99.06% <100.00%> (+<0.01%)`	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

yoyo837 · 2023-03-17T03:48:41Z

src/Table.tsx

-        );
-
+        if (props.columns.length > 0) {
+          warning(


为啥不把if的条件放warning的判断参数上?

我来改一下

afc163 · 2023-03-17T03:51:33Z

tests/Table.spec.js

@@ -701,6 +701,24 @@ describe('Table.Basic', () => {
      });
    });

+    it('without warning - columns is emplty', () => {


我顺带改一下吧

#972 被大佬抢了

fix: table warning message when columns=[]

659bc01

vercel bot deployed to Preview March 13, 2023 13:05 View deployment

zombieJ merged commit ae3bc5b into react-component:master Mar 17, 2023

yoyo837 reviewed Mar 17, 2023

View reviewed changes

afc163 reviewed Mar 17, 2023

View reviewed changes

Francoshum95 deleted the fix/41150-fix-warning branch March 18, 2023 22:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: table warning message when columns=[] #966

fix: table warning message when columns=[] #966

Francoshum95 commented Mar 13, 2023 •

edited by zombieJ

Loading

vercel bot commented Mar 13, 2023 •

edited

Loading

codecov bot commented Mar 17, 2023

yoyo837 Mar 17, 2023 •

edited

Loading

afc163 Mar 17, 2023

kiner-tang Mar 17, 2023

afc163 Mar 17, 2023

kiner-tang Mar 17, 2023

yoyo837 Mar 17, 2023

fix: table warning message when columns=[] #966

fix: table warning message when columns=[] #966

Conversation

Francoshum95 commented Mar 13, 2023 • edited by zombieJ Loading

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

☑️ Self-Check before Merge

vercel bot commented Mar 13, 2023 • edited Loading

codecov bot commented Mar 17, 2023

Codecov Report

yoyo837 Mar 17, 2023 • edited Loading

Choose a reason for hiding this comment

afc163 Mar 17, 2023

Choose a reason for hiding this comment

kiner-tang Mar 17, 2023

Choose a reason for hiding this comment

afc163 Mar 17, 2023

Choose a reason for hiding this comment

kiner-tang Mar 17, 2023

Choose a reason for hiding this comment

yoyo837 Mar 17, 2023

Choose a reason for hiding this comment

Francoshum95 commented Mar 13, 2023 •

edited by zombieJ

Loading

vercel bot commented Mar 13, 2023 •

edited

Loading

yoyo837 Mar 17, 2023 •

edited

Loading