Fixed the scrolling issue occurring in mobile #431
Conversation
We tried to scroll from the particular element in mobile it preventing to scroll. When we removed the `e.preventDefault(); ` working fine for Us. Thanks!
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/tabs/5KTaUfMcRKF6PTeRB1vRXYzSREVF |
| @@ -30,8 +30,6 @@ export default function useTouchMove( | |||
|
|
|||
| function onTouchMove(e: TouchEvent) { | |||
| if (!touchPosition) return; | |||
|
|
|||
| e.preventDefault(); | |||
There was a problem hiding this comment.
Should prevent by move direct instead. Not remove directly
There was a problem hiding this comment.
Should prevent by move direct instead. Not remove directly
What “prevent by move direct ” means?
There was a problem hiding this comment.
For horizontal preventDefault with up & down but not block with left & right. And vertical is prevent up & down but not left & right.
There was a problem hiding this comment.
For horizontal preventDefault with up & down but not block with left & right. And vertical is prevent up & down but not left & right.
It seems @pplcallmesatz didn't make some new commits. Why can't you just fix the bug?
|
Fixed in #622 |
We tried to scroll from the particular element in mobile it preventing to scroll. When we removed the
e.preventDefault();working fine for Us.Thanks!
resolve #368