Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Tabs use items instead of jsx node #562

Merged
merged 9 commits into from
Aug 4, 2022
Merged

refactor: Tabs use items instead of jsx node #562

merged 9 commits into from
Aug 4, 2022

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Aug 3, 2022

No description provided.

@vercel
Copy link

vercel bot commented Aug 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
tabs ✅ Ready (Inspect) Visit Preview Aug 3, 2022 at 11:01AM (UTC)

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #562 (8e5619d) into master (76f66f3) will increase coverage by 0.17%.
The diff coverage is 100.00%.

❗ Current head 8e5619d differs from pull request most recent head 63a78c8. Consider uploading reports for the commit 63a78c8 to get more accurate results

@@            Coverage Diff             @@
##           master     #562      +/-   ##
==========================================
+ Coverage   99.46%   99.64%   +0.17%     
==========================================
  Files          13       14       +1     
  Lines         565      562       -3     
  Branches      142      139       -3     
==========================================
- Hits          562      560       -2     
+ Misses          3        2       -1     
Impacted Files Coverage Δ
src/TabNavList/index.tsx 99.45% <ø> (ø)
src/TabNavList/OperationNode.tsx 100.00% <100.00%> (ø)
src/TabNavList/TabNode.tsx 100.00% <100.00%> (+3.22%) ⬆️
src/TabNavList/Wrapper.tsx 100.00% <100.00%> (ø)
src/TabPanelList/index.tsx 88.88% <100.00%> (-1.12%) ⬇️
src/Tabs.tsx 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@danny007in
Copy link

in items, how can import

       <Tabs defaultActiveKey="1">
                <TabPane tab="Circular Charts" key="1">
                  <ChartJsCircular />
                </TabPane>
                <TabPane tab="Lines & Bars Charts" key="2">
                  <ChartJsLinesBars />
                </TabPane>
              </Tabs>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants