fix: Make event listeners passive - useTouchMove.ts #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
从Chrome 117版本开始就出现了警告信息。 我希望这个问题能尽快修改。
|
|
好早我都提交 PR，但管理员一直没审核，没并入。 |
|
Hi @zombieJ @afc163 @li-jia-nan I noticed that this PR addresses this issue, but it appears to be pending. (There's also an earlier duplicate of PR #625 ) Would it be possible to review and merge this PR? This fix is quite urgent for my project as it impacts performance and user experience. Your assistance would be greatly appreciated. Thank you for your time and contribution to this great library! Best regards, |
|
Fixed in #723 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Violation] Added non-passive event listener to a scroll-blocking 'wheel' event. Consider marking event handler as 'passive' to make the page more responsive.