fix: offset四舍五入导致hiddenTabs计算逻辑错误 #667
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zombieJ
reviewed
Jul 7, 2023
src/TabNavList/index.tsx
Outdated
| const { offsetWidth = 0, offsetHeight = 0 } = refObj.current || {}; | ||
| return [offsetWidth, offsetHeight]; | ||
| const { width = 0, height = 0 } = refObj?.current?.getBoundingClientRect() || {}; | ||
| return [width, height]; |
There was a problem hiding this comment.
added 2 commits
July 26, 2023 16:28
…tabs into fix/offset_excute_error
|
Any update on this? |
|
如果tab内部没有scale，使用 getBoundingClientRect本身就是个错 出现这个的原因是这里 tabs/src/hooks/useVisibleRange.ts Line 41 in 2e015f6 floating numer的运算，导致本来想等的变大于了, 毕竟js |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2023-07-07.14.19.32.mov
antd复现的Bug，相关issue: ant-design/ant-design#39079