Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: apply destroyInactiveTabPane from the TabPane #675

Merged
merged 4 commits into from
Oct 16, 2023

Conversation

ChuckJonas
Copy link
Contributor

@vercel
Copy link

vercel bot commented Oct 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tabs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2023 2:21am

@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Merging #675 (98bab61) into master (0bce955) will increase coverage by 0.00%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 98bab61 differs from pull request most recent head 130e279. Consider uploading reports for the commit 130e279 to get more accurate results

@@           Coverage Diff           @@
##           master     #675   +/-   ##
=======================================
  Coverage   97.72%   97.72%           
=======================================
  Files          18       18           
  Lines         659      660    +1     
  Branches      176      171    -5     
=======================================
+ Hits          644      645    +1     
  Misses         15       15           
Files Coverage Δ
src/TabNavList/index.tsx 95.42% <ø> (ø)
src/TabPanelList/index.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zombieJ zombieJ merged commit 72ca369 into react-component:master Oct 16, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Destroy Inactive tab does not work when set at tab level
2 participants