Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed constructor bug in IE10 #145

Closed
wants to merge 1 commit into from

Conversation

codeflyer
Copy link

The props are not available in the constructor in IE10, adding a check on this.props before using it helps to prevent an error.

The props are not available in the constructor in IE10, adding a check on this.props before using it helps and prevent an error.
@STRML
Copy link
Collaborator

STRML commented Mar 21, 2016

Is this a Babel bug?

@STRML
Copy link
Collaborator

STRML commented Mar 21, 2016

Perhaps proto-to-assign will fix this - see https://babeljs.algolia.com/docs/advanced/caveats/#internet-explorer

@codeflyer
Copy link
Author

Thanks for the quick answer, I'm checking, I'll let you know ASAP

@codeflyer
Copy link
Author

I've tried to add the transform but i still have the error:
"unable to get property 'start' of undefined or null reference"

[
'transform-es2015-block-scoping',
['transform-es2015-classes', {loose: true}],
'transform-proto-to-assign'
]

With this solution the call of a constructor works and if I try to log the props in the constructor are finally available (without this transform thy are not available babel/babelify#133)

But in the code you don't use a contructor, but static calls.

...I'll continue on my search

@STRML
Copy link
Collaborator

STRML commented May 19, 2016

This was fixed in #158.

@STRML STRML closed this May 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants