V2 - better modules support #104
Conversation
|
This is super exciting! |
|
@bluebill1049 PR ready for review 🙂 |
|
Wow, this is cool! |
| "license": "MIT", | ||
| "peerDependencies": { | ||
| "react-hook-form": ">=6.6.0", | ||
| "@hookform/resolvers": "^1.0.0" |
There was a problem hiding this comment.
Yes, to import convertArrayToPathName, inspiration from preact
| "umd": "./superstruct/dist/superstruct.umd.js", | ||
| "import": "./superstruct/dist/superstruct.mjs", | ||
| "require": "./superstruct/dist/superstruct.js" | ||
| }, |
| "prepare": "run-s build && check-export-map", | ||
| "build": "npm-run-all --parallel build:*", | ||
| "build:src": "microbundle build", | ||
| "build:zod": "microbundle --cwd zod --globals '@hookform/resolvers=hookformResolvers'", |
There was a problem hiding this comment.
That's new to me, --globals
There was a problem hiding this comment.
It specify variable name for external imports in umd/iife bundles
I suggest to publish a V2 beta because there are lot of changes (project structure, bundles etc...) And we can advise users to try beta and collect feedbacks. What do you think ? |
sounds good to me! The only thing to beware that their argument of resolver may change with v7, we didn't document the third argument in the readme tho, just in case someone is using it. |
|
🎉 This PR is included in version 1.3.2-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
First of all, huge thank to the preact hard work. This PR is heavily inspired of their modules structure.
Good news, no breaking changes ! users can import resolvers as usual 🎉
Tested with Next.js and CRA with success ✅ ! Others formats will be tested after first beta release
Solves #71 & #100