-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(context): inject context into yup context #30
feat(context): inject context into yup context #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! LGTM.
I go to -> #26 (comment). |
@Vandell63 you happy for this PR to be merged? |
Of course yes :) if it is all fine for you 👍 |
Tried to migrate to react-hook-form 6.0.7 with "@hookform/resolvers": "^0.0.6", but my yup schema is not actually used and validation passes with invalid values:
|
@tommedema provide a codesandbox |
@tommedema please can you retry with this shape instead and give me your feedback ?
Or if you want your context to be used inside of the yup options with abortEarly set to false
|
Hey there,
-> #29
Test + context injected
I prefer to don't dive test because i will make another mr for -> #26 (comment).
And then push test to 100%