Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

fix(ios): Xcode12 build run on device crash #70

Merged
merged 1 commit into from
Nov 9, 2020
Merged

fix(ios): Xcode12 build run on device crash #70

merged 1 commit into from
Nov 9, 2020

Conversation

layneios
Copy link
Contributor

@layneios layneios commented Sep 18, 2020

Summary

Fixing the issues outlined in #29721

20200919105840

Reason

Since the ARTShadow structure holds a color object, it will cause a zombie object after destruction.

Test Plan

Ran the example project

What's required for testing (prerequisites)?

  • Xcode 12

What are the steps to reproduce (after prerequisites)?

  • Build and run the example project

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator

Since the ARTShadow structure holds a color object, it will cause a zombie object after destruction.
@michbil
Copy link

michbil commented Sep 20, 2020

@lengmolehongyan I have failed to build your fix. Got couple of syntax errors. Is it verified solution you posted?

@layneios
Copy link
Contributor Author

@lengmolehongyan I have failed to build your fix. Got couple of syntax errors. Is it verified solution you posted?

Yeah, verified, would you mind uploading these build syntax errors?

@michbil
Copy link

michbil commented Sep 21, 2020

@lengmolehongyan Never mind, I made error during patch, that's why there was errors. Your fix seems to work fine for me. Thank you!

@tsdmrfth
Copy link

tsdmrfth commented Oct 6, 2020

I am facing with same issue. When it is planned to merge?

@efornaro
Copy link

The patch is good, but merging is blocked. Could anyone with write access approve the changes? Thanks.

@Esemesek Esemesek merged commit b71f5f4 into react-native-art:master Nov 9, 2020
@v-honcharenko
Copy link

Can this update be released asap?

@chakrihacker
Copy link

Please release an update thanks

@gustavogialim
Copy link

I've tried to apply this patch and got malformed error, anyone else also had problems with it?
image

@michbil maybe is the same problem that you had and solved next, is it?

@gustavogialim
Copy link

About the error above I just remove the '100%' on height sizes and worked well, the height prop looks support only numbers.

@kadanes
Copy link

kadanes commented Jun 19, 2021

Why has this still not been released as part of a new release?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.