New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove explicit SDK version for Windows builds #177

Merged

Naturalclar merged 2 commits into react-native-clipboard:master from chrisglein:sdkVersion

Sep 25, 2023

Contributor

chrisglein commented Mar 24, 2023

Overview

Fix SDK build error if 10.0.18362.0 is not installed:

× Building Solution: C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Microsoft\VC\v170\Microsoft...
× Build failed with message C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Microsoft\VC\v170\Microsoft.Cpp.WindowsSDK.targets(46,5): error MSB8036: The Windows SDK version 10.0.18362.0 was not found. Install the required version of Windows SDK or change the SDK version in the project property pages or by right-clicking the solution and selecting "Retarget solution".

See react-native-async-storage/async-storage#810 for a similar fix.

Previously, after bringing down package dependencies you'd have to retarget the SDK version for the module project.

Test Plan

Committed to a fork and redirected an app with a Windows build to this. Build error goes away.

jonthysell approved these changes

View reviewed changes

windows/Clipboard/Clipboard.vcxproj Outdated Show resolved Hide resolved


          Remove explicit SDK version

16bc4ad

See react-native-async-storage/async-storage#810

SDK import defers to app preference

Keep SDK version neutral

chrisglein force-pushed the sdkVersion branch from a12c2c7 to 16bc4ad Compare

September 14, 2023 18:07

TatianaKapos approved these changes

View reviewed changes

jonthysell approved these changes

View reviewed changes

windows/Clipboard/Clipboard.vcxproj Outdated Show resolved Hide resolved

windows/Clipboard/Clipboard.vcxproj Show resolved Hide resolved


          Update Cpp.Default.props order per feedback

4ac73be

jonthysell approved these changes

View reviewed changes

chrisglein mentioned this pull request

Remove explicit SDK version for Windows builds TheWidlarzGroup/react-native-video#3246

Merged

1 task

chrisglein added a commit to chrisglein/artificial-chat that referenced this pull request


          Updating clipboard patch to match PR

ee411bb

react-native-clipboard/clipboard#177

Naturalclar approved these changes

View reviewed changes

Naturalclar merged commit ddd4b9e into react-native-clipboard:master

chrisglein added a commit to chrisglein/artificial-chat that referenced this pull request


          Remove clipboard patch

5f2dcca

react-native-clipboard/clipboard#177

chrisglein mentioned this pull request

node_modules\react-native-document-picker\windows\ReactNativeDocumentPicker\ReactNativeDocumentPicker.csproj : error NU1201: Project Microsoft.ReactNative.Managed is not compatible with uap10.0.16299 (UAP,Version=v10.0.16299). Project Microsoft.ReactNative.Managed supports: uap10.0.17763 (UAP,Version=v10.0.17763 react-native-documents/document-picker#676

Closed

renovate bot referenced this pull request in valora-inc/wallet


          fix(deps): update dependency @react-native-clipboard/clipboard to ^1.…

79acccb

…12.1 (#4251)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@react-native-clipboard/clipboard](https://togithub.com/react-native-clipboard/clipboard)
| [`^1.11.2` ->
`^1.12.1`](https://renovatebot.com/diffs/npm/@react-native-clipboard%2fclipboard/1.11.2/1.12.1)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@react-native-clipboard%2fclipboard/1.12.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@react-native-clipboard%2fclipboard/1.12.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@react-native-clipboard%2fclipboard/1.11.2/1.12.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@react-native-clipboard%2fclipboard/1.11.2/1.12.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>react-native-clipboard/clipboard
(@&#8203;react-native-clipboard/clipboard)</summary>

###
[`v1.12.1`](https://togithub.com/react-native-clipboard/clipboard/releases/tag/v1.12.1)

[Compare
Source](https://togithub.com/react-native-clipboard/clipboard/compare/v1.11.2...v1.12.1)

#### What's Changed

- Change node version on CI by
[@&#8203;Naturalclar](https://togithub.com/Naturalclar) in
[https://github.com/react-native-clipboard/clipboard/pull/185](https://togithub.com/react-native-clipboard/clipboard/pull/185)
- chore(deps): bump minimatch from 3.0.4 to 3.1.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/react-native-clipboard/clipboard/pull/171](https://togithub.com/react-native-clipboard/clipboard/pull/171)
- chore(deps): bump ua-parser-js from 0.7.28 to 0.7.33 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/react-native-clipboard/clipboard/pull/167](https://togithub.com/react-native-clipboard/clipboard/pull/167)
- Fix warnings: new NativeEventEmitter() was called with a non-null arg…
by [@&#8203;chrisglein](https://togithub.com/chrisglein) in
[https://github.com/react-native-clipboard/clipboard/pull/175](https://togithub.com/react-native-clipboard/clipboard/pull/175)
- Use existing clipData instead of calling getPrimaryClip() again by
[@&#8203;djkazic](https://togithub.com/djkazic) in
[https://github.com/react-native-clipboard/clipboard/pull/188](https://togithub.com/react-native-clipboard/clipboard/pull/188)
- Update node version in Github actions by
[@&#8203;Naturalclar](https://togithub.com/Naturalclar) in
[https://github.com/react-native-clipboard/clipboard/pull/202](https://togithub.com/react-native-clipboard/clipboard/pull/202)
- Update node version in ci by
[@&#8203;Naturalclar](https://togithub.com/Naturalclar) in
[https://github.com/react-native-clipboard/clipboard/pull/204](https://togithub.com/react-native-clipboard/clipboard/pull/204)
- Remove explicit SDK version for Windows builds by
[@&#8203;chrisglein](https://togithub.com/chrisglein) in
[https://github.com/react-native-clipboard/clipboard/pull/177](https://togithub.com/react-native-clipboard/clipboard/pull/177)

#### New Contributors

- [@&#8203;djkazic](https://togithub.com/djkazic) made their first
contribution in
[https://github.com/react-native-clipboard/clipboard/pull/188](https://togithub.com/react-native-clipboard/clipboard/pull/188)

**Full Changelog**:
react-native-clipboard/clipboard@v1.12.0...v1.12.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjMiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Satish Ravi <satish.ravi@valoraapp.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet