-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warnings: new NativeEventEmitter() was called with a non-null argument #207
Merged
Naturalclar
merged 1 commit into
react-native-clipboard:master
from
espipj:fix/EventEmittersWarning
Oct 20, 2023
Merged
Fix warnings: new NativeEventEmitter() was called with a non-null argument #207
Naturalclar
merged 1 commit into
react-native-clipboard:master
from
espipj:fix/EventEmittersWarning
Oct 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Naturalclar any chance you could take a look at this? |
Naturalclar
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
renovate bot
referenced
this pull request
in valora-inc/wallet
Jan 5, 2024
…13.0 (#4648) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@react-native-clipboard/clipboard](https://togithub.com/react-native-clipboard/clipboard) | [`^1.12.1` -> `^1.13.0`](https://renovatebot.com/diffs/npm/@react-native-clipboard%2fclipboard/1.12.1/1.13.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@react-native-clipboard%2fclipboard/1.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@react-native-clipboard%2fclipboard/1.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@react-native-clipboard%2fclipboard/1.12.1/1.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@react-native-clipboard%2fclipboard/1.12.1/1.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>react-native-clipboard/clipboard (@​react-native-clipboard/clipboard)</summary> ### [`v1.13.0`](https://togithub.com/react-native-clipboard/clipboard/releases/tag/v1.13.0) [Compare Source](https://togithub.com/react-native-clipboard/clipboard/compare/v1.12.1...v1.13.0) #### What's Changed - Fix warnings: new NativeEventEmitter() was called with a non-null argument by [@​espipj](https://togithub.com/espipj) in [https://github.com/react-native-clipboard/clipboard/pull/207](https://togithub.com/react-native-clipboard/clipboard/pull/207) - Android RN 72 Support - Update build.gradle w/ Namespace by [@​alexhernandez](https://togithub.com/alexhernandez) in [https://github.com/react-native-clipboard/clipboard/pull/192](https://togithub.com/react-native-clipboard/clipboard/pull/192) - Add new architecture support - convert library to turbomodule by [@​j-piasecki](https://togithub.com/j-piasecki) in [https://github.com/react-native-clipboard/clipboard/pull/169](https://togithub.com/react-native-clipboard/clipboard/pull/169) - chore(deps): bump semver from 5.7.1 to 5.7.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/react-native-clipboard/clipboard/pull/191](https://togithub.com/react-native-clipboard/clipboard/pull/191) - chore(deps): bump word-wrap from 1.2.3 to 1.2.5 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/react-native-clipboard/clipboard/pull/203](https://togithub.com/react-native-clipboard/clipboard/pull/203) - chore(deps): bump react-devtools-core from 4.8.2 to 4.28.4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/react-native-clipboard/clipboard/pull/211](https://togithub.com/react-native-clipboard/clipboard/pull/211) #### New Contributors - [@​espipj](https://togithub.com/espipj) made their first contribution in [https://github.com/react-native-clipboard/clipboard/pull/207](https://togithub.com/react-native-clipboard/clipboard/pull/207) - [@​alexhernandez](https://togithub.com/alexhernandez) made their first contribution in [https://github.com/react-native-clipboard/clipboard/pull/192](https://togithub.com/react-native-clipboard/clipboard/pull/192) - [@​j-piasecki](https://togithub.com/j-piasecki) made their first contribution in [https://github.com/react-native-clipboard/clipboard/pull/169](https://togithub.com/react-native-clipboard/clipboard/pull/169) **Full Changelog**: react-native-clipboard/clipboard@v1.12.1...v1.13.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy45My4xIiwidXBkYXRlZEluVmVyIjoiMzcuOTMuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com> Co-authored-by: Tom McGuire <Mcgtom10@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #116
Similar fix applied on #175 but for iOS/Macos supresses the NativeEventEmitter warning
Test Plan
Build/Open the Macos or iOS apps and you should see no warning
Reference: react-native-netinfo/react-native-netinfo#487