Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update React Native minimum version supported, fix test app autolinking #235

Merged
merged 5 commits into from
Apr 13, 2024

Conversation

Saadnajmi
Copy link
Contributor

Overview

In #227, I accidentally made the minimum react-native dependency 0.73. Since the PR itself has no source code changes (only test app changes) that wasn't necessary. This PR brings the minimum back down to RN 0.57. I did this by:

  • Updating the rnx-kit configs to set development (and test app) to 0.73, while production to 0.57
  • Run yarn rnx-align-deps --write
  • Remove the rnx-kit configs altogether as they aren't actually necessary (more a tool to help with upgrades, and can be used without having a config in your package.json).
    • This does mean if someone came and ran npx @rnx-kit/align-deps@latest --requirements react-native@0.74 or something later, it would bump the minimum to 0.74 and not take into account the minimum. I figure nobody will do this, so safe to remove.

Also, from #230, I realized we were no longer auto linking RNCClipboard in our test app. This is due to autolinking not following yarn workspaces. We can fix this by adding the extra dependencies key to our react-native.config.js to help the react native CLI auto link the library.

Furthermore, after talking with @tido64 , I realized I had set up the test app a bit off. I had two package.json files: one at the root and one for the example app. With this approach, we would need two react native configs. A more common setup amongst RN community modules is to only have one package.json and react-native config. This meant some more refactoring to bring the test app in line with other repos, and ensure autolinking still worked with Yarn 4.

End result is a working modern test app :)

Test Plan

Test app boots and loads the module correctly on iOS.

Screenshot 2024-04-10 at 5 05 39 AM

@Saadnajmi Saadnajmi changed the title Fix fallout from #227 and #230 Update React Native minimum version supported, fix test app autolinking Apr 10, 2024
react-native.config.js Outdated Show resolved Hide resolved
Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
react-native.config.js Outdated Show resolved Hide resolved
Saadnajmi and others added 2 commits April 10, 2024 05:40
Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
Copy link
Member

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Naturalclar Naturalclar merged commit 03ce8c1 into react-native-clipboard:master Apr 13, 2024
github-merge-queue bot referenced this pull request in valora-inc/wallet Apr 30, 2024
…14.1 (#5371)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@react-native-clipboard/clipboard](https://togithub.com/react-native-clipboard/clipboard)
| [`^1.13.2` ->
`^1.14.1`](https://renovatebot.com/diffs/npm/@react-native-clipboard%2fclipboard/1.13.2/1.14.1)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@react-native-clipboard%2fclipboard/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@react-native-clipboard%2fclipboard/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@react-native-clipboard%2fclipboard/1.13.2/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@react-native-clipboard%2fclipboard/1.13.2/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>react-native-clipboard/clipboard
(@&#8203;react-native-clipboard/clipboard)</summary>

###
[`v1.14.1`](https://togithub.com/react-native-clipboard/clipboard/releases/tag/v1.14.1)

[Compare
Source](https://togithub.com/react-native-clipboard/clipboard/compare/v1.14.0...v1.14.1)

#### What's Changed

- add missing `getEnforcing` jest mock by
[@&#8203;siddarthkay](https://togithub.com/siddarthkay) in
[https://github.com/react-native-clipboard/clipboard/pull/220](https://togithub.com/react-native-clipboard/clipboard/pull/220)
- Use Yarn 4 by [@&#8203;Saadnajmi](https://togithub.com/Saadnajmi) in
[https://github.com/react-native-clipboard/clipboard/pull/230](https://togithub.com/react-native-clipboard/clipboard/pull/230)
- fix: eslint config by
[@&#8203;Naturalclar](https://togithub.com/Naturalclar) in
[https://github.com/react-native-clipboard/clipboard/pull/232](https://togithub.com/react-native-clipboard/clipboard/pull/232)
- fix: android ci by
[@&#8203;Naturalclar](https://togithub.com/Naturalclar) in
[https://github.com/react-native-clipboard/clipboard/pull/233](https://togithub.com/react-native-clipboard/clipboard/pull/233)
- Update React Native minimum version supported, fix test app
autolinking by [@&#8203;Saadnajmi](https://togithub.com/Saadnajmi) in
[https://github.com/react-native-clipboard/clipboard/pull/235](https://togithub.com/react-native-clipboard/clipboard/pull/235)
- fix: module spec mis-match on Android (new Architecture) by
[@&#8203;alanleedev](https://togithub.com/alanleedev) in
[https://github.com/react-native-clipboard/clipboard/pull/237](https://togithub.com/react-native-clipboard/clipboard/pull/237)

#### New Contributors

- [@&#8203;siddarthkay](https://togithub.com/siddarthkay) made their
first contribution in
[https://github.com/react-native-clipboard/clipboard/pull/220](https://togithub.com/react-native-clipboard/clipboard/pull/220)
- [@&#8203;alanleedev](https://togithub.com/alanleedev) made their first
contribution in
[https://github.com/react-native-clipboard/clipboard/pull/237](https://togithub.com/react-native-clipboard/clipboard/pull/237)

**Full Changelog**:
react-native-clipboard/clipboard@v1.14.0...v1.14.1

###
[`v1.14.0`](https://togithub.com/react-native-clipboard/clipboard/compare/v1.13.2...v1.14.0)

[Compare
Source](https://togithub.com/react-native-clipboard/clipboard/compare/v1.13.2...v1.14.0)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: valora-bot <valorabot@valoraapp.com>
github-merge-queue bot referenced this pull request in valora-inc/wallet Apr 30, 2024
…14.1 (#5371)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@react-native-clipboard/clipboard](https://togithub.com/react-native-clipboard/clipboard)
| [`^1.13.2` ->
`^1.14.1`](https://renovatebot.com/diffs/npm/@react-native-clipboard%2fclipboard/1.13.2/1.14.1)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@react-native-clipboard%2fclipboard/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@react-native-clipboard%2fclipboard/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@react-native-clipboard%2fclipboard/1.13.2/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@react-native-clipboard%2fclipboard/1.13.2/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>react-native-clipboard/clipboard
(@&#8203;react-native-clipboard/clipboard)</summary>

###
[`v1.14.1`](https://togithub.com/react-native-clipboard/clipboard/releases/tag/v1.14.1)

[Compare
Source](https://togithub.com/react-native-clipboard/clipboard/compare/v1.14.0...v1.14.1)

#### What's Changed

- add missing `getEnforcing` jest mock by
[@&#8203;siddarthkay](https://togithub.com/siddarthkay) in
[https://github.com/react-native-clipboard/clipboard/pull/220](https://togithub.com/react-native-clipboard/clipboard/pull/220)
- Use Yarn 4 by [@&#8203;Saadnajmi](https://togithub.com/Saadnajmi) in
[https://github.com/react-native-clipboard/clipboard/pull/230](https://togithub.com/react-native-clipboard/clipboard/pull/230)
- fix: eslint config by
[@&#8203;Naturalclar](https://togithub.com/Naturalclar) in
[https://github.com/react-native-clipboard/clipboard/pull/232](https://togithub.com/react-native-clipboard/clipboard/pull/232)
- fix: android ci by
[@&#8203;Naturalclar](https://togithub.com/Naturalclar) in
[https://github.com/react-native-clipboard/clipboard/pull/233](https://togithub.com/react-native-clipboard/clipboard/pull/233)
- Update React Native minimum version supported, fix test app
autolinking by [@&#8203;Saadnajmi](https://togithub.com/Saadnajmi) in
[https://github.com/react-native-clipboard/clipboard/pull/235](https://togithub.com/react-native-clipboard/clipboard/pull/235)
- fix: module spec mis-match on Android (new Architecture) by
[@&#8203;alanleedev](https://togithub.com/alanleedev) in
[https://github.com/react-native-clipboard/clipboard/pull/237](https://togithub.com/react-native-clipboard/clipboard/pull/237)

#### New Contributors

- [@&#8203;siddarthkay](https://togithub.com/siddarthkay) made their
first contribution in
[https://github.com/react-native-clipboard/clipboard/pull/220](https://togithub.com/react-native-clipboard/clipboard/pull/220)
- [@&#8203;alanleedev](https://togithub.com/alanleedev) made their first
contribution in
[https://github.com/react-native-clipboard/clipboard/pull/237](https://togithub.com/react-native-clipboard/clipboard/pull/237)

**Full Changelog**:
react-native-clipboard/clipboard@v1.14.0...v1.14.1

###
[`v1.14.0`](https://togithub.com/react-native-clipboard/clipboard/compare/v1.13.2...v1.14.0)

[Compare
Source](https://togithub.com/react-native-clipboard/clipboard/compare/v1.13.2...v1.14.0)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: valora-bot <valorabot@valoraapp.com>
github-merge-queue bot referenced this pull request in valora-inc/wallet Apr 30, 2024
…14.1 (#5371)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@react-native-clipboard/clipboard](https://togithub.com/react-native-clipboard/clipboard)
| [`^1.13.2` ->
`^1.14.1`](https://renovatebot.com/diffs/npm/@react-native-clipboard%2fclipboard/1.13.2/1.14.1)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@react-native-clipboard%2fclipboard/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@react-native-clipboard%2fclipboard/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@react-native-clipboard%2fclipboard/1.13.2/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@react-native-clipboard%2fclipboard/1.13.2/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>react-native-clipboard/clipboard
(@&#8203;react-native-clipboard/clipboard)</summary>

###
[`v1.14.1`](https://togithub.com/react-native-clipboard/clipboard/releases/tag/v1.14.1)

[Compare
Source](https://togithub.com/react-native-clipboard/clipboard/compare/v1.14.0...v1.14.1)

#### What's Changed

- add missing `getEnforcing` jest mock by
[@&#8203;siddarthkay](https://togithub.com/siddarthkay) in
[https://github.com/react-native-clipboard/clipboard/pull/220](https://togithub.com/react-native-clipboard/clipboard/pull/220)
- Use Yarn 4 by [@&#8203;Saadnajmi](https://togithub.com/Saadnajmi) in
[https://github.com/react-native-clipboard/clipboard/pull/230](https://togithub.com/react-native-clipboard/clipboard/pull/230)
- fix: eslint config by
[@&#8203;Naturalclar](https://togithub.com/Naturalclar) in
[https://github.com/react-native-clipboard/clipboard/pull/232](https://togithub.com/react-native-clipboard/clipboard/pull/232)
- fix: android ci by
[@&#8203;Naturalclar](https://togithub.com/Naturalclar) in
[https://github.com/react-native-clipboard/clipboard/pull/233](https://togithub.com/react-native-clipboard/clipboard/pull/233)
- Update React Native minimum version supported, fix test app
autolinking by [@&#8203;Saadnajmi](https://togithub.com/Saadnajmi) in
[https://github.com/react-native-clipboard/clipboard/pull/235](https://togithub.com/react-native-clipboard/clipboard/pull/235)
- fix: module spec mis-match on Android (new Architecture) by
[@&#8203;alanleedev](https://togithub.com/alanleedev) in
[https://github.com/react-native-clipboard/clipboard/pull/237](https://togithub.com/react-native-clipboard/clipboard/pull/237)

#### New Contributors

- [@&#8203;siddarthkay](https://togithub.com/siddarthkay) made their
first contribution in
[https://github.com/react-native-clipboard/clipboard/pull/220](https://togithub.com/react-native-clipboard/clipboard/pull/220)
- [@&#8203;alanleedev](https://togithub.com/alanleedev) made their first
contribution in
[https://github.com/react-native-clipboard/clipboard/pull/237](https://togithub.com/react-native-clipboard/clipboard/pull/237)

**Full Changelog**:
react-native-clipboard/clipboard@v1.14.0...v1.14.1

###
[`v1.14.0`](https://togithub.com/react-native-clipboard/clipboard/compare/v1.13.2...v1.14.0)

[Compare
Source](https://togithub.com/react-native-clipboard/clipboard/compare/v1.13.2...v1.14.0)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: valora-bot <valorabot@valoraapp.com>
shottah referenced this pull request in zed-io/kolektivo May 15, 2024
…14.1 (valora-inc#5371)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@react-native-clipboard/clipboard](https://togithub.com/react-native-clipboard/clipboard)
| [`^1.13.2` ->
`^1.14.1`](https://renovatebot.com/diffs/npm/@react-native-clipboard%2fclipboard/1.13.2/1.14.1)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@react-native-clipboard%2fclipboard/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@react-native-clipboard%2fclipboard/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@react-native-clipboard%2fclipboard/1.13.2/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@react-native-clipboard%2fclipboard/1.13.2/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>react-native-clipboard/clipboard
(@&#8203;react-native-clipboard/clipboard)</summary>

###
[`v1.14.1`](https://togithub.com/react-native-clipboard/clipboard/releases/tag/v1.14.1)

[Compare
Source](https://togithub.com/react-native-clipboard/clipboard/compare/v1.14.0...v1.14.1)

#### What's Changed

- add missing `getEnforcing` jest mock by
[@&#8203;siddarthkay](https://togithub.com/siddarthkay) in
[https://github.com/react-native-clipboard/clipboard/pull/220](https://togithub.com/react-native-clipboard/clipboard/pull/220)
- Use Yarn 4 by [@&#8203;Saadnajmi](https://togithub.com/Saadnajmi) in
[https://github.com/react-native-clipboard/clipboard/pull/230](https://togithub.com/react-native-clipboard/clipboard/pull/230)
- fix: eslint config by
[@&#8203;Naturalclar](https://togithub.com/Naturalclar) in
[https://github.com/react-native-clipboard/clipboard/pull/232](https://togithub.com/react-native-clipboard/clipboard/pull/232)
- fix: android ci by
[@&#8203;Naturalclar](https://togithub.com/Naturalclar) in
[https://github.com/react-native-clipboard/clipboard/pull/233](https://togithub.com/react-native-clipboard/clipboard/pull/233)
- Update React Native minimum version supported, fix test app
autolinking by [@&#8203;Saadnajmi](https://togithub.com/Saadnajmi) in
[https://github.com/react-native-clipboard/clipboard/pull/235](https://togithub.com/react-native-clipboard/clipboard/pull/235)
- fix: module spec mis-match on Android (new Architecture) by
[@&#8203;alanleedev](https://togithub.com/alanleedev) in
[https://github.com/react-native-clipboard/clipboard/pull/237](https://togithub.com/react-native-clipboard/clipboard/pull/237)

#### New Contributors

- [@&#8203;siddarthkay](https://togithub.com/siddarthkay) made their
first contribution in
[https://github.com/react-native-clipboard/clipboard/pull/220](https://togithub.com/react-native-clipboard/clipboard/pull/220)
- [@&#8203;alanleedev](https://togithub.com/alanleedev) made their first
contribution in
[https://github.com/react-native-clipboard/clipboard/pull/237](https://togithub.com/react-native-clipboard/clipboard/pull/237)

**Full Changelog**:
react-native-clipboard/clipboard@v1.14.0...v1.14.1

###
[`v1.14.0`](https://togithub.com/react-native-clipboard/clipboard/compare/v1.13.2...v1.14.0)

[Compare
Source](https://togithub.com/react-native-clipboard/clipboard/compare/v1.13.2...v1.14.0)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: valora-bot <valorabot@valoraapp.com>
@Saadnajmi Saadnajmi deleted the minimums branch May 30, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants