-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update React Native minimum version supported, fix test app autolinking #235
Merged
Naturalclar
merged 5 commits into
react-native-clipboard:master
from
Saadnajmi:minimums
Apr 13, 2024
Merged
Update React Native minimum version supported, fix test app autolinking #235
Naturalclar
merged 5 commits into
react-native-clipboard:master
from
Saadnajmi:minimums
Apr 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
changed the title
Fix fallout from #227 and #230
Update React Native minimum version supported, fix test app autolinking
Apr 10, 2024
tido64
reviewed
Apr 10, 2024
Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
tido64
reviewed
Apr 10, 2024
Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
Naturalclar
approved these changes
Apr 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
github-merge-queue bot
referenced
this pull request
in valora-inc/wallet
Apr 30, 2024
…14.1 (#5371) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@react-native-clipboard/clipboard](https://togithub.com/react-native-clipboard/clipboard) | [`^1.13.2` -> `^1.14.1`](https://renovatebot.com/diffs/npm/@react-native-clipboard%2fclipboard/1.13.2/1.14.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@react-native-clipboard%2fclipboard/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@react-native-clipboard%2fclipboard/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@react-native-clipboard%2fclipboard/1.13.2/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@react-native-clipboard%2fclipboard/1.13.2/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>react-native-clipboard/clipboard (@​react-native-clipboard/clipboard)</summary> ### [`v1.14.1`](https://togithub.com/react-native-clipboard/clipboard/releases/tag/v1.14.1) [Compare Source](https://togithub.com/react-native-clipboard/clipboard/compare/v1.14.0...v1.14.1) #### What's Changed - add missing `getEnforcing` jest mock by [@​siddarthkay](https://togithub.com/siddarthkay) in [https://github.com/react-native-clipboard/clipboard/pull/220](https://togithub.com/react-native-clipboard/clipboard/pull/220) - Use Yarn 4 by [@​Saadnajmi](https://togithub.com/Saadnajmi) in [https://github.com/react-native-clipboard/clipboard/pull/230](https://togithub.com/react-native-clipboard/clipboard/pull/230) - fix: eslint config by [@​Naturalclar](https://togithub.com/Naturalclar) in [https://github.com/react-native-clipboard/clipboard/pull/232](https://togithub.com/react-native-clipboard/clipboard/pull/232) - fix: android ci by [@​Naturalclar](https://togithub.com/Naturalclar) in [https://github.com/react-native-clipboard/clipboard/pull/233](https://togithub.com/react-native-clipboard/clipboard/pull/233) - Update React Native minimum version supported, fix test app autolinking by [@​Saadnajmi](https://togithub.com/Saadnajmi) in [https://github.com/react-native-clipboard/clipboard/pull/235](https://togithub.com/react-native-clipboard/clipboard/pull/235) - fix: module spec mis-match on Android (new Architecture) by [@​alanleedev](https://togithub.com/alanleedev) in [https://github.com/react-native-clipboard/clipboard/pull/237](https://togithub.com/react-native-clipboard/clipboard/pull/237) #### New Contributors - [@​siddarthkay](https://togithub.com/siddarthkay) made their first contribution in [https://github.com/react-native-clipboard/clipboard/pull/220](https://togithub.com/react-native-clipboard/clipboard/pull/220) - [@​alanleedev](https://togithub.com/alanleedev) made their first contribution in [https://github.com/react-native-clipboard/clipboard/pull/237](https://togithub.com/react-native-clipboard/clipboard/pull/237) **Full Changelog**: react-native-clipboard/clipboard@v1.14.0...v1.14.1 ### [`v1.14.0`](https://togithub.com/react-native-clipboard/clipboard/compare/v1.13.2...v1.14.0) [Compare Source](https://togithub.com/react-native-clipboard/clipboard/compare/v1.13.2...v1.14.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
github-merge-queue bot
referenced
this pull request
in valora-inc/wallet
Apr 30, 2024
…14.1 (#5371) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@react-native-clipboard/clipboard](https://togithub.com/react-native-clipboard/clipboard) | [`^1.13.2` -> `^1.14.1`](https://renovatebot.com/diffs/npm/@react-native-clipboard%2fclipboard/1.13.2/1.14.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@react-native-clipboard%2fclipboard/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@react-native-clipboard%2fclipboard/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@react-native-clipboard%2fclipboard/1.13.2/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@react-native-clipboard%2fclipboard/1.13.2/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>react-native-clipboard/clipboard (@​react-native-clipboard/clipboard)</summary> ### [`v1.14.1`](https://togithub.com/react-native-clipboard/clipboard/releases/tag/v1.14.1) [Compare Source](https://togithub.com/react-native-clipboard/clipboard/compare/v1.14.0...v1.14.1) #### What's Changed - add missing `getEnforcing` jest mock by [@​siddarthkay](https://togithub.com/siddarthkay) in [https://github.com/react-native-clipboard/clipboard/pull/220](https://togithub.com/react-native-clipboard/clipboard/pull/220) - Use Yarn 4 by [@​Saadnajmi](https://togithub.com/Saadnajmi) in [https://github.com/react-native-clipboard/clipboard/pull/230](https://togithub.com/react-native-clipboard/clipboard/pull/230) - fix: eslint config by [@​Naturalclar](https://togithub.com/Naturalclar) in [https://github.com/react-native-clipboard/clipboard/pull/232](https://togithub.com/react-native-clipboard/clipboard/pull/232) - fix: android ci by [@​Naturalclar](https://togithub.com/Naturalclar) in [https://github.com/react-native-clipboard/clipboard/pull/233](https://togithub.com/react-native-clipboard/clipboard/pull/233) - Update React Native minimum version supported, fix test app autolinking by [@​Saadnajmi](https://togithub.com/Saadnajmi) in [https://github.com/react-native-clipboard/clipboard/pull/235](https://togithub.com/react-native-clipboard/clipboard/pull/235) - fix: module spec mis-match on Android (new Architecture) by [@​alanleedev](https://togithub.com/alanleedev) in [https://github.com/react-native-clipboard/clipboard/pull/237](https://togithub.com/react-native-clipboard/clipboard/pull/237) #### New Contributors - [@​siddarthkay](https://togithub.com/siddarthkay) made their first contribution in [https://github.com/react-native-clipboard/clipboard/pull/220](https://togithub.com/react-native-clipboard/clipboard/pull/220) - [@​alanleedev](https://togithub.com/alanleedev) made their first contribution in [https://github.com/react-native-clipboard/clipboard/pull/237](https://togithub.com/react-native-clipboard/clipboard/pull/237) **Full Changelog**: react-native-clipboard/clipboard@v1.14.0...v1.14.1 ### [`v1.14.0`](https://togithub.com/react-native-clipboard/clipboard/compare/v1.13.2...v1.14.0) [Compare Source](https://togithub.com/react-native-clipboard/clipboard/compare/v1.13.2...v1.14.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
github-merge-queue bot
referenced
this pull request
in valora-inc/wallet
Apr 30, 2024
…14.1 (#5371) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@react-native-clipboard/clipboard](https://togithub.com/react-native-clipboard/clipboard) | [`^1.13.2` -> `^1.14.1`](https://renovatebot.com/diffs/npm/@react-native-clipboard%2fclipboard/1.13.2/1.14.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@react-native-clipboard%2fclipboard/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@react-native-clipboard%2fclipboard/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@react-native-clipboard%2fclipboard/1.13.2/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@react-native-clipboard%2fclipboard/1.13.2/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>react-native-clipboard/clipboard (@​react-native-clipboard/clipboard)</summary> ### [`v1.14.1`](https://togithub.com/react-native-clipboard/clipboard/releases/tag/v1.14.1) [Compare Source](https://togithub.com/react-native-clipboard/clipboard/compare/v1.14.0...v1.14.1) #### What's Changed - add missing `getEnforcing` jest mock by [@​siddarthkay](https://togithub.com/siddarthkay) in [https://github.com/react-native-clipboard/clipboard/pull/220](https://togithub.com/react-native-clipboard/clipboard/pull/220) - Use Yarn 4 by [@​Saadnajmi](https://togithub.com/Saadnajmi) in [https://github.com/react-native-clipboard/clipboard/pull/230](https://togithub.com/react-native-clipboard/clipboard/pull/230) - fix: eslint config by [@​Naturalclar](https://togithub.com/Naturalclar) in [https://github.com/react-native-clipboard/clipboard/pull/232](https://togithub.com/react-native-clipboard/clipboard/pull/232) - fix: android ci by [@​Naturalclar](https://togithub.com/Naturalclar) in [https://github.com/react-native-clipboard/clipboard/pull/233](https://togithub.com/react-native-clipboard/clipboard/pull/233) - Update React Native minimum version supported, fix test app autolinking by [@​Saadnajmi](https://togithub.com/Saadnajmi) in [https://github.com/react-native-clipboard/clipboard/pull/235](https://togithub.com/react-native-clipboard/clipboard/pull/235) - fix: module spec mis-match on Android (new Architecture) by [@​alanleedev](https://togithub.com/alanleedev) in [https://github.com/react-native-clipboard/clipboard/pull/237](https://togithub.com/react-native-clipboard/clipboard/pull/237) #### New Contributors - [@​siddarthkay](https://togithub.com/siddarthkay) made their first contribution in [https://github.com/react-native-clipboard/clipboard/pull/220](https://togithub.com/react-native-clipboard/clipboard/pull/220) - [@​alanleedev](https://togithub.com/alanleedev) made their first contribution in [https://github.com/react-native-clipboard/clipboard/pull/237](https://togithub.com/react-native-clipboard/clipboard/pull/237) **Full Changelog**: react-native-clipboard/clipboard@v1.14.0...v1.14.1 ### [`v1.14.0`](https://togithub.com/react-native-clipboard/clipboard/compare/v1.13.2...v1.14.0) [Compare Source](https://togithub.com/react-native-clipboard/clipboard/compare/v1.13.2...v1.14.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
shottah
referenced
this pull request
in zed-io/kolektivo
May 15, 2024
…14.1 (valora-inc#5371) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@react-native-clipboard/clipboard](https://togithub.com/react-native-clipboard/clipboard) | [`^1.13.2` -> `^1.14.1`](https://renovatebot.com/diffs/npm/@react-native-clipboard%2fclipboard/1.13.2/1.14.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@react-native-clipboard%2fclipboard/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@react-native-clipboard%2fclipboard/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@react-native-clipboard%2fclipboard/1.13.2/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@react-native-clipboard%2fclipboard/1.13.2/1.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>react-native-clipboard/clipboard (@​react-native-clipboard/clipboard)</summary> ### [`v1.14.1`](https://togithub.com/react-native-clipboard/clipboard/releases/tag/v1.14.1) [Compare Source](https://togithub.com/react-native-clipboard/clipboard/compare/v1.14.0...v1.14.1) #### What's Changed - add missing `getEnforcing` jest mock by [@​siddarthkay](https://togithub.com/siddarthkay) in [https://github.com/react-native-clipboard/clipboard/pull/220](https://togithub.com/react-native-clipboard/clipboard/pull/220) - Use Yarn 4 by [@​Saadnajmi](https://togithub.com/Saadnajmi) in [https://github.com/react-native-clipboard/clipboard/pull/230](https://togithub.com/react-native-clipboard/clipboard/pull/230) - fix: eslint config by [@​Naturalclar](https://togithub.com/Naturalclar) in [https://github.com/react-native-clipboard/clipboard/pull/232](https://togithub.com/react-native-clipboard/clipboard/pull/232) - fix: android ci by [@​Naturalclar](https://togithub.com/Naturalclar) in [https://github.com/react-native-clipboard/clipboard/pull/233](https://togithub.com/react-native-clipboard/clipboard/pull/233) - Update React Native minimum version supported, fix test app autolinking by [@​Saadnajmi](https://togithub.com/Saadnajmi) in [https://github.com/react-native-clipboard/clipboard/pull/235](https://togithub.com/react-native-clipboard/clipboard/pull/235) - fix: module spec mis-match on Android (new Architecture) by [@​alanleedev](https://togithub.com/alanleedev) in [https://github.com/react-native-clipboard/clipboard/pull/237](https://togithub.com/react-native-clipboard/clipboard/pull/237) #### New Contributors - [@​siddarthkay](https://togithub.com/siddarthkay) made their first contribution in [https://github.com/react-native-clipboard/clipboard/pull/220](https://togithub.com/react-native-clipboard/clipboard/pull/220) - [@​alanleedev](https://togithub.com/alanleedev) made their first contribution in [https://github.com/react-native-clipboard/clipboard/pull/237](https://togithub.com/react-native-clipboard/clipboard/pull/237) **Full Changelog**: react-native-clipboard/clipboard@v1.14.0...v1.14.1 ### [`v1.14.0`](https://togithub.com/react-native-clipboard/clipboard/compare/v1.13.2...v1.14.0) [Compare Source](https://togithub.com/react-native-clipboard/clipboard/compare/v1.13.2...v1.14.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In #227, I accidentally made the minimum react-native dependency
0.73
. Since the PR itself has no source code changes (only test app changes) that wasn't necessary. This PR brings the minimum back down to RN 0.57. I did this by:yarn rnx-align-deps --write
npx @rnx-kit/align-deps@latest --requirements react-native@0.74
or something later, it would bump the minimum to 0.74 and not take into account the minimum. I figure nobody will do this, so safe to remove.Also, from #230, I realized we were no longer auto linking RNCClipboard in our test app. This is due to autolinking not following yarn workspaces. We can fix this by adding the extra
dependencies
key to ourreact-native.config.js
to help the react native CLI auto link the library.Furthermore, after talking with @tido64 , I realized I had set up the test app a bit off. I had two package.json files: one at the root and one for the example app. With this approach, we would need two react native configs. A more common setup amongst RN community modules is to only have one package.json and react-native config. This meant some more refactoring to bring the test app in line with other repos, and ensure autolinking still worked with Yarn 4.
End result is a working modern test app :)
Test Plan
Test app boots and loads the module correctly on iOS.